Skip to content

Commit a0aa4dd

Browse files
committed
Fix AWS nio tests [ci fast]
Signed-off-by: Paolo Di Tommaso <[email protected]>
1 parent 46f5023 commit a0aa4dd

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,8 @@ jobs:
7979
echo $GOOGLE_SECRET | base64 -d > $PWD/google_credentials.json
8080
export GOOGLE_APPLICATION_CREDENTIALS=$PWD/google_credentials.json
8181
fi
82+
export AWS_S3FS_ACCESS_KEY=${AWS_ACCESS_KEY_ID}
83+
export AWS_S3FS_SECRET_KEY=${AWS_SECRET_ACCESS_KEY}
8284
# run tests
8385
make test
8486
env:
@@ -95,6 +97,7 @@ jobs:
9597
AZURE_BATCH_ACCOUNT_KEY: ${{ secrets.AZURE_BATCH_ACCOUNT_KEY }}
9698

9799
- name: Publish tests report
100+
if: always()
98101
uses: actions/upload-artifact@v4
99102
with:
100103
name: report-unit-tests-jdk-${{ matrix.java_version }}

plugins/nf-amazon/src/main/nextflow/cloud/aws/nio/S3FileSystemProvider.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,8 @@ public <V extends FileAttributeView> V getFileAttributeView(Path path, Class<V>
669669
throw new RuntimeException("Unable read attributes for file: " + FilesEx.toUriString(s3Path), e);
670670
}
671671
}
672-
throw new UnsupportedOperationException("Not a valid S3 file system provider file attribute view: " + type.getName());
672+
log.trace("Unsupported S3 file system provider file attribute view: " + type.getName());
673+
return null;
673674
}
674675

675676

plugins/nf-amazon/src/test/nextflow/cloud/aws/nio/AwsS3NioTest.groovy

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ import java.nio.file.StandardOpenOption
3131
import java.nio.file.attribute.BasicFileAttributes
3232

3333
import com.amazonaws.services.s3.AmazonS3
34-
import com.amazonaws.services.s3.model.AmazonS3Exception
3534
import com.amazonaws.services.s3.model.Tag
3635
import groovy.util.logging.Slf4j
3736
import nextflow.Global

0 commit comments

Comments
 (0)