fix(bg_jobs): store job argument as a text, increase length cap to 32000#59029
Merged
provokateurin merged 2 commits intomasterfrom Mar 19, 2026
Merged
fix(bg_jobs): store job argument as a text, increase length cap to 32000#59029provokateurin merged 2 commits intomasterfrom
provokateurin merged 2 commits intomasterfrom
Conversation
Member
provokateurin
left a comment
There was a problem hiding this comment.
I question a bit why you'd need so much space for arguments, maybe some kind of reference should be passed instead?
miaulalala
requested changes
Mar 18, 2026
Contributor
Author
Maybe, but I don't know if that's up to app developers to handle? IIRC and see ref issues, webhook_listeners are expecting to have complete information, e.g. there could be usecases like:
To my understanding, current PR would be the less invasive approach to support larger data arrays? |
2cf72ad to
746fddf
Compare
provokateurin
approved these changes
Mar 18, 2026
miaulalala
approved these changes
Mar 18, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…4000 to 32000 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
904c45d to
0c5feae
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After internal discussion it comes up, that
$argument_hashis used in DB queries for references, and$argumentshould be safe to store as a Type::TEXT. That should allow to increase the max length of JSON encoded string without breaking the DB 🤞🏽TODO
Checklist
Screenshots before/after for front-end changes3. to review, feature component)stable32)AI (if applicable)