Inform users of missing files in archive#58895
Closed
salmart-dev wants to merge 2 commits intomasterfrom
Closed
Conversation
5fe8953 to
9b42f6a
Compare
kesselb
reviewed
Mar 12, 2026
9b42f6a to
5ddc8b0
Compare
…wnload folder with non-downloadable files Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
946a530 to
309a528
Compare
fa71715 to
7f73824
Compare
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
7f73824 to
a783e8e
Compare
Contributor
Author
|
Closing in favor of: #59049 (branch name corrected with feature) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took over some of the changes from #57335, thanks @Koc
Summary
The
ZipFolderPluginhalts the streaming of an archive for download due to various factors, such as storage issues with a file, temporary database problems, or a lost network connection. Because the plugin streams without acontent-lengthheader, the user receives an incomplete archive without any warning. In some cases, this issue only becomes apparent when attempting to open a file in the archive and discovering that the entire archive is corrupted.This PR partially addresses the problem by introducing a new working mode for the plugin. If the configuration value for
archive_report_missing_filesis set totruethe following happens:missing_files.jsonfile is added within the archive if any file or directories are missing due to errors, along with the causeTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)