common logic to detect ua

Signed-off-by: Chandrika Mohan <chandrikalov@gmail.com>

Author: chandrika1993

apps/settings/src/components/AuthToken.spec.ts

@@ -4,62 +4,52 @@
  */
 
 import { describe, expect, it } from 'vitest'
-import { userAgentMap } from '../utils/userAgentMap.ts'
-
-// Helper: iterate map in order, return first match (mirrors AuthToken.vue client computed)
-function detect(ua: string) {
-	for (const [id, regex] of Object.entries(userAgentMap)) {
-		const m = ua.match(regex)
-		if (m) {
-			return { id, version: m[2] ?? m[1], os: m[2] ? m[1] : null }
-		}
-	}
-	return null
-}
-
-// Android Chrome
+import { detect } from '../utils/userAgentDetect.ts'
 
 describe('Android Chrome detection', () => {
 	it('modern Android Chrome (no Build/ string, post-2021) should match androidChrome', () => {
 		const ua = 'Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Mobile Safari/537.36'
-		const result = detect(ua)
-		expect(result?.id).toBe('androidChrome')
-		expect(result?.version).toBe('132')
+		expect(detect(ua)).toEqual({
+			id: 'androidChrome',
+			version: '132',
+		})
 	})
 
 	it('legacy Android Chrome (with Build/ string, pre-2021) should match androidChrome', () => {
 		const ua = 'Mozilla/5.0 (Linux; Android 10; SM-G973F Build/QP1A) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Mobile Safari/537.36'
-		const result = detect(ua)
-		expect(result?.id).toBe('androidChrome')
-		expect(result?.version).toBe('130')
+		expect(detect(ua)).toEqual({
+			id: 'androidChrome',
+			version: '130',
+		})
 	})
 
 	it('Android Chrome on tablet (no "Mobile" in UA) should match androidChrome', () => {
 		const ua = 'Mozilla/5.0 (Linux; Android 13) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36'
-		const result = detect(ua)
-		expect(result?.id).toBe('androidChrome')
-		expect(result?.version).toBe('131')
+		expect(detect(ua)).toEqual({
+			id: 'androidChrome',
+			version: '131',
+		})
 	})
 })
 
-// Desktop Chrome regressions
-
 describe('Desktop Chrome regression tests', () => {
 	it('Desktop Chrome on Linux should still match chrome', () => {
 		const ua = 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36'
-		const result = detect(ua)
-		expect(result?.id).toBe('chrome')
-		expect(result?.version).toBe('132')
+		expect(detect(ua)).toEqual({
+			id: 'chrome',
+			version: '132',
+			os: 'Linux',
+		})
 	})
 })
 
-// Desktop Firefox regressions
-
 describe('Desktop Firefox regression tests', () => {
 	it('Desktop Firefox on Linux should still match firefox', () => {
 		const ua = 'Mozilla/5.0 (X11; Linux x86_64; rv:124.0) Gecko/20100101 Firefox/124.0'
-		const result = detect(ua)
-		expect(result?.id).toBe('firefox')
-		expect(result?.version).toBe('124')
+		expect(detect(ua)).toEqual({
+			id: 'firefox',
+			version: '124',
+			os: 'Linux',
+		})
 	})
 })

apps/settings/src/components/AuthToken.vue

@@ -100,7 +100,7 @@ import NcDateTime from '@nextcloud/vue/components/NcDateTime'
 import NcIconSvgWrapper from '@nextcloud/vue/components/NcIconSvgWrapper'
 import NcTextField from '@nextcloud/vue/components/NcTextField'
 import { TokenType, useAuthTokenStore } from '../store/authtoken.ts'
-import { userAgentMap } from '../utils/userAgentMap.ts'
+import { detect } from '../utils/userAgentDetect.ts'
 
 const nameMap = {
 	edge: 'Microsoft Edge',
@@ -176,18 +176,7 @@ export default defineComponent({
 				}
 			}
 
-			for (const client in userAgentMap) {
-				const matches = this.token.name.match(userAgentMap[client])
-				if (matches) {
-					return {
-						id: client,
-						os: matches[2] && matches[1],
-						version: matches[2] ?? matches[1],
-					}
-				}
-			}
-
-			return null
+			return detect(this.token.name)
 		},
 
 		/**

apps/settings/src/utils/userAgentDetect.ts

@@ -0,0 +1,33 @@
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import { userAgentMap } from './userAgentMap.ts'
+
+export interface DetectedUserAgent {
+	id: string
+	version?: string
+	os?: string
+}
+
+/**
+ * Detect the client from a user agent string.
+ *
+ * @param ua Raw user agent string
+ * @return Detected client information or null if unknown
+ */
+export function detect(ua: string): DetectedUserAgent | null {
+	for (const id in userAgentMap) {
+		const matches = ua.match(userAgentMap[id])
+		if (matches) {
+			return {
+				id,
+				version: matches[2] ?? matches[1],
+				os: matches[2] && matches[1],
+			}
+		}
+	}
+
+	return null
+}

dist/settings-vue-settings-personal-security.js

@@ -1,5 +1,5 @@
 /* extracted by css-entry-points-plugin */
-@import './theming-theming-settings-personal-BGvZ2soH.chunk.css';
+@import './theming-theming-settings-personal-Tw2nBJ_u.chunk.css';
 @import './createElementId-DhjFt1I9-C_oBIsvc.chunk.css';
 @import './autolink-U5pBzLgI-R3us1MM8.chunk.css';
 @import './NcModal-DHryP_87-CU2wYsLf.chunk.css';