feat: delay fetching the display name of a share recipient untill we need it

Signed-off-by: Robin Appelman <robin@icewind.nl>

Author: icewind1991

lib/private/Share20/DefaultShareProvider.php

@@ -1096,16 +1096,10 @@ private function createShare($data) {
 
 		if ($share->getShareType() === IShare::TYPE_USER) {
 			$share->setSharedWith($data['share_with']);
-			$displayName = $this->userManager->getDisplayName($data['share_with']);
-			if ($displayName !== null) {
-				$share->setSharedWithDisplayName($displayName);
-			}
+			$share->setSharedWithDisplayNameCallback(fn (IShare $share) => $this->userManager->getDisplayName($share->getSharedWith()));
 		} elseif ($share->getShareType() === IShare::TYPE_GROUP) {
 			$share->setSharedWith($data['share_with']);
-			$group = $this->groupManager->get($data['share_with']);
-			if ($group !== null) {
-				$share->setSharedWithDisplayName($group->getDisplayName());
-			}
+			$share->setSharedWithDisplayNameCallback(fn (IShare $share) => $this->groupManager->getDisplayName($share->getSharedWith()));
 		} elseif ($share->getShareType() === IShare::TYPE_LINK) {
 			$share->setPassword($data['password']);
 			$share->setSendPasswordByTalk((bool)$data['password_by_talk']);
@@ -1462,6 +1456,7 @@ public function getAccessList($nodes, $currentAccess) {
 
 	/**
 	 * For each user the path with the fewest slashes is returned
+	 *
 	 * @param array $shares
 	 * @return array
 	 */

lib/private/Share20/Share.php

@@ -33,8 +33,9 @@ class Share implements IShare {
 	private $shareType;
 	/** @var string */
 	private $sharedWith;
-	/** @var string */
-	private $sharedWithDisplayName;
+	private ?string $sharedWithDisplayName;
+	/** @var ?callable */
+	private $sharedWithDisplayNameCallback;
 	/** @var string */
 	private $sharedWithAvatar;
 	/** @var string */
@@ -247,9 +248,19 @@ public function setSharedWithDisplayName($displayName) {
 	}
 
 	/**
-	 * @inheritdoc
+	 * @param callable(IShare):?string $callback
+	 * @return $this
 	 */
+	public function setSharedWithDisplayNameCallback(callable $callback) {
+		$this->sharedWithDisplayNameCallback = $callback;
+		return $this;
+	}
+
 	public function getSharedWithDisplayName() {
+		if ($this->sharedWithDisplayNameCallback !== null) {
+			$this->sharedWithDisplayName = ($this->sharedWithDisplayNameCallback)($this);
+			$this->sharedWithDisplayNameCallback = null;
+		}
 		return $this->sharedWithDisplayName;
 	}