fix(lookup-server): accept self-signed lus on globalscale

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Author: ArtificialOwl

lib/private/Collaboration/Collaborators/LookupPlugin.php

@@ -54,11 +54,16 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b
 
 		try {
 			$client = $this->clientService->newClient();
+			/**
+			 * @psalm-suppress TypeDoesNotContainType - $isGlobalScaleEnabled always true at this point
+			 * @psalm-suppress RedundantCondition - guard rail in case we re-activate LUS out of GlobalScale
+			 */
 			$response = $client->get(
 				$lookupServerUrl . '/users?search=' . urlencode($search),
 				[
 					'timeout' => 10,
 					'connect_timeout' => 3,
+					'verify' => !($isGlobalScaleEnabled && $this->config->getSystemValueBool('gss.selfsigned.allow', false) === true)
 				]
 			);
 

tests/lib/Collaboration/Collaborators/LookupPluginTest.php

@@ -139,11 +139,12 @@ public function testSearch(array $searchParams): void {
 			->method('getAppValue')
 			->with('files_sharing', 'lookupServerEnabled', 'no')
 			->willReturn('yes');
-		$this->config->expects($this->exactly(2))
+		$this->config->expects($this->exactly(3))
 			->method('getSystemValueBool')
 			->willReturnMap([
 				['gs.enabled', false, true],
 				['has_internet_connection', true, true],
+				['gss.selfsigned.allow', false, false],
 			]);
 
 		$this->config->expects($this->once())
@@ -201,11 +202,12 @@ public function testSearchEnableDisableLookupServer(array $searchParams, $GSEnab
 				->method('addResultSet')
 				->with($type, $searchParams['expectedResult'], []);
 
-			$this->config->expects($this->exactly(2))
+			$this->config->expects($this->exactly(3))
 				->method('getSystemValueBool')
 				->willReturnMap([
 					['gs.enabled', false, $GSEnabled],
 					['has_internet_connection', true, true],
+					['gss.selfsigned.allow', false, false],
 				]);
 			$this->config->expects($this->once())
 				->method('getSystemValueString')