Skip to content

feat(http): centralize Content-Disposition header generation #75743

feat(http): centralize Content-Disposition header generation

feat(http): centralize Content-Disposition header generation #75743

Triggered via pull request March 22, 2026 15:39
Status Failure
Total duration 6m 0s
Artifacts

static-code-analysis.yml

on: pull_request
static-code-analysis
2m 9s
static-code-analysis
static-code-analysis-security
5m 56s
static-code-analysis-security
static-code-analysis-ocp
57s
static-code-analysis-ocp
static-code-analysis-ncu
38s
static-code-analysis-ncu
static-code-analysis-strict
52s
static-code-analysis-strict
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 5 warnings
static-code-analysis
Process completed with exit code 2.
LessSpecificReturnStatement: apps/settings/lib/Controller/LogSettingsController.php#L42
apps/settings/lib/Controller/LogSettingsController.php:42:10: LessSpecificReturnStatement: The type 'OCP\AppFramework\Http\StreamResponse<200, array{'Content-Disposition': string, 'Content-Type': 'application/octet-stream'}>' is more general than the declared return type 'OCP\AppFramework\Http\StreamResponse<200, array{'Content-Disposition': 'attachment; filename=\"nextcloud.log\"', 'Content-Type': 'application/octet-stream'}>' for OCA\Settings\Controller\LogSettingsController::download (see https://psalm.dev/129)
MoreSpecificReturnType: apps/settings/lib/Controller/LogSettingsController.php#L32
apps/settings/lib/Controller/LogSettingsController.php:32:13: MoreSpecificReturnType: The declared return type 'OCP\AppFramework\Http\StreamResponse<200, array{'Content-Disposition': 'attachment; filename=\"nextcloud.log\"', 'Content-Type': 'application/octet-stream'}>' for OCA\Settings\Controller\LogSettingsController::download is more specific than the inferred return type 'OCP\AppFramework\Http\StreamResponse<200, array{'Content-Disposition': string, 'Content-Type': 'application/octet-stream'}>' (see https://psalm.dev/070)
TaintedCallable: lib/private/ServerContainer.php#L89
lib/private/ServerContainer.php:89:17: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
TaintedHtml: lib/private/Mail/Mailer.php#L229
lib/private/Mail/Mailer.php:229:72: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)
TaintedHtml: lib/private/Mail/Mailer.php#L209
lib/private/Mail/Mailer.php:209:83: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)
TaintedCallable: lib/private/AppFramework/Utility/SimpleContainer.php#L126
lib/private/AppFramework/Utility/SimpleContainer.php:126:33: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
TaintedCallable: apps/workflowengine/lib/Manager.php#L502
apps/workflowengine/lib/Manager.php:502:39: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
TaintedCallable: apps/workflowengine/lib/Manager.php#L469
apps/workflowengine/lib/Manager.php:469:38: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
TaintedCallable: apps/workflowengine/lib/Manager.php#L427
apps/workflowengine/lib/Manager.php:427:38: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
static-code-analysis-ncu
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
static-code-analysis-strict
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
static-code-analysis-ocp
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
static-code-analysis
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
static-code-analysis-security
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/