add unit tests for UserDeletedListener functionality #12114
+199
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comprehensive unit tests for the UserDeletedListener to ensure proper handling of user deletion events, including scenarios with no accounts, single and multiple accounts, client exceptions, and partial failures. This enhances test coverage and reliability of the mail account deletion process. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
kesselb
reviewed
Dec 1, 2025
Contributor
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
Thank you 🙏
Some smaller nitpicks, but overall a good initiative to add a test for it.
| $this->assertInstanceOf(\OCP\EventDispatcher\IEventListener::class, $this->listener); | ||
| } | ||
|
|
||
| public function testHandleMethodHasOverrideAttribute(): void { |
Contributor
There was a problem hiding this comment.
Why would you have a test for that?
| ); | ||
| } | ||
|
|
||
| private function createUserMock(string $userId = 'test-user'): IUser&MockObject { |
Contributor
There was a problem hiding this comment.
Suggested change
| private function createUserMock(string $userId = 'test-user'): IUser&MockObject { | |
| private function createUserMock(string $userId): IUser&MockObject { |
Not using a default makes the test easier to read because the value is given when used.
| } | ||
|
|
||
| private function createAccountMock(int $id): Account&MockObject { | ||
| $account = $this->createMock(Account::class); |
Contributor
There was a problem hiding this comment.
Account is mostly an DTO. Nicer would be, because we are not working with a test double, to instantiate a new object and only mock the MailAccount object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comprehensive unit tests for the UserDeletedListener to ensure proper handling of user deletion events, including scenarios with no accounts, single and multiple accounts, client exceptions, and partial failures. This enhances test coverage and reliability of the mail account deletion process.
In order for us to extend the logic in the future