Skip to content

fix: favorite reactivity #12112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: favorite reactivity #12112

wants to merge 3 commits into from

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Dec 1, 2025 •
edited
Loading

Ho to test:

  1. checkout feat: pin favorites #12111
  2. Have favorite and non favorite messages in a mailbox
  3. toggle favorite state for one message and watch it not update pinned state
  4. cherry-pick this commit and test again

@hamza221 hamza221 added the bug label Dec 1, 2025
@hamza221 hamza221 mentioned this pull request Dec 1, 2025
Open
4 tasks
@hamza221 hamza221 changed the title fix: favority reactivity fix: favorite reactivity Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hamza221