[Spring MVC] 진웨이얀 3,4단게 미션제출합니다 #517
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanxiu
reviewed
Nov 23, 2025
| package roomescape; | ||
|
|
||
|
|
||
| public class Reservation{ |
There was a problem hiding this comment.
파일 경로를 변경해볼까요? /controller 와 /dto 를 분리하면 좋을 것 같습니다
| return ResponseEntity.noContent().build(); | ||
| } | ||
|
|
||
| // Exception Handler |
| // Exception Handler | ||
| public class NotFoundReservationException extends RuntimeException {} | ||
| public class BadRequestReservationException extends RuntimeException {} | ||
| @ExceptionHandler({BadRequestReservationException.class, NotFoundReservationException.class}) |
There was a problem hiding this comment.
NotFound 에러는 404 코드를 던지는 게 좋을 것 같아요! 현재는 Bad request 로 처리하고 있네요. 별도 메서드로 분리해볼까요?
|
|
||
| // Create | ||
| @PostMapping("/reservations") | ||
| public ResponseEntity<Reservation> add_reservation(@RequestBody Reservation reservation){ |
There was a problem hiding this comment.
메서드명이 snake case 로 되어있네요.Java 컨벤션에서 메서드명은 camelCase 을 주로 사용합니다 :)
| @PostMapping("/reservations") | ||
| public ResponseEntity<Reservation> add_reservation(@RequestBody Reservation reservation){ | ||
| // handle exception -> any required field empty | ||
| if(isBlank(reservation.getName()) || isBlank(reservation.getDate()) || isBlank(reservation.getTime())){ |
There was a problem hiding this comment.
파라미터 입력을 수동으로 검증을 하고 있네요. Valid 어노테이션을 사용해볼까요? 이 글 을 참고하면, DTO 의 필드 입력을 컨트롤러에서 검증하는 Valid 어노테이션 동작을 이해하는 데 도움될 것 같습니다!
juanxiu
reviewed
Nov 23, 2025
| return time; | ||
| } | ||
|
|
||
| public static Reservation toEntity(Reservation reservation,Long id){ |
There was a problem hiding this comment.
정적 팩토리 메서드는 엔티티와 DTO 가 분리되었을 때 객체 생성을 위해서 사용하는 메서드입니다. 현재는 DTO 만 존재하니 필요하지 않을 것 같습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.