add fips compliant packages #506
Open
+129
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajrohanyadav
force-pushed
the
NR-287123-add-fips-compliant-pkgs
branch
8 times, most recently
from
cc3f01e to
738b9a2
Compare
rajrohanyadav
force-pushed
the
NR-287123-add-fips-compliant-pkgs
branch
from
2cebdd4 to
e6b10e4
Compare
paologallinaharbur
previously approved these changes
Dec 11, 2024
rajrohanyadav
force-pushed
the
NR-287123-add-fips-compliant-pkgs
branch
from
e6b10e4 to
4db3204
Compare
paologallinaharbur
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to support creating FIPS packages. For initial release we don't need FIPS images. Currently,
goreleaseris being used to create and tag docker images fornri-prometheus. For FIPS, we need to create the binaries inside a container built using the centralized builder image:ghcr.io/newrelic/coreint-automation:latest-go1.23.4-ubuntu16.04.We'll have to add
dockerandbuildxdependencies to the image which are additional dependencies to maintain. It was tried with this PR.I've tried to balance the mess and keep it only in this repo until we can fix it rather than adding unnecessary things to other repos.
Note:
TODOto remove image creation fromgoreleaserand potentially use reusable workflow here.Testing
Prerelease test
