Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: apply type coercion, at least for integer based values #2935

Open
fallwith opened this issue Nov 4, 2024 · 1 comment
Open

Config: apply type coercion, at least for integer based values #2935

fallwith opened this issue Nov 4, 2024 · 1 comment
Assignees

Comments

@fallwith
Copy link
Contributor

fallwith commented Nov 4, 2024

We have some configuration parameter value type coercion logic parked in the lab branch which is a) passing all CI tests, b) received dev approval, and c) passed csec tests for known integer handling issues.

Our CI suites involve lots and lots of iterations that completely flush and entirely reinitialize all agent configuration and layering in type coercion does have a performance impact that is easily seen in a CI context. Before merging the type coercion logic in, we'd like to be absolutely sure that the performance hit is expected to be slight outside of a CI context.

As a fallback plan, we should at least incorporate integer focused coercion for the csec agent's benefit.

@fallwith fallwith self-assigned this Nov 4, 2024
@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Quarter
Development

No branches or pull requests

1 participant