Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to decorate automatically instrumented HTTPClient Spans with Attributes #2889

Open
TraGicCode opened this issue Nov 18, 2024 · 3 comments
Labels
community To tag external issues and PRs

Comments

@TraGicCode
Copy link

TraGicCode commented Nov 18, 2024

Is there currently a way, or can there be a way, to allow users to attach "custom attributes" to individual automatically instrumented HTTP client request spans? It would be great to create dashboards for automatically instrumented HTTP client calls while also using custom attributes on those calls. For example, this could enable graphing calls per tenant to analyze response codes across tenants. Does this make sense or is it even possible to do this using the current .net newrelic agent?

@workato-integration
Copy link

@github-actions github-actions bot added the community To tag external issues and PRs label Nov 18, 2024
@TraGicCode TraGicCode changed the title Ability to add "custom attributes" to httpclient calls Ability to decorate automatically instrumented HTTPClient Spans with Attributes Nov 18, 2024
@nr-ahemsath
Copy link
Member

Sorry for not responding to this for three weeks, @TraGicCode. It's been hectic with the Thanksgiving holiday. Somebody should take a look at this soon.

@jaffinito
Copy link
Member

We do offer an API to add custom attributes to spans, but ensuring that you are setting them on the HttpClient span is going to be difficult. it would be easier and more reliable to set custom attributes on the transaction instead.

Another potential option, if the values are present as headers, would be to enable capture request headers on spans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs
Projects
None yet
Development

No branches or pull requests

3 participants