Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions are not automatically collected to Errors Inbox in gRPC servers #2589

Open
AnhQuanTrl opened this issue Jul 2, 2024 · 3 comments
Labels
community To tag external issues and PRs feature request To tag an issue after triage that is a feature instead of TD

Comments

@AnhQuanTrl
Copy link

When an exception is thrown in a gRPC server's request, it is not automatically collected and sent to Errors Inbox.

Description
When an exception is thrown in a gRPC server's request, it is not automatically collected and sent to Errors Inbox. This is in contrast with Rest API when any unhandled exceptions are automatically collected by the agent and sent to NR in Errors Inbox. We are currently creating Alerts based on percentage of errors and have noticed no errors are reported for gRPC servers.

Expected Behavior
Unhandled gRPC exceptions should also be collected to Errors Inbox, similar to how exceptions in REST API.

Troubleshooting or NR Diag results
[NOTE]: # ( Provide any other relevant log data such as the agent and/or profiler logs, preferably at DEBUG level or higher. )
[TIP]: # ( Scrub logs and diagnostic information for sensitive information )

Steps to Reproduce

  1. Create a gRPC server following the example.
  2. Add some REST API using traditional controllers for comparision.
  3. Install .NET agent in Linux.
  4. Add dummy exceptions to both gRPC requests and REST request and verify that unhandled gRPC exceptions are not collected as Error Events, while REST exceptions are.

Your Environment
.NET Core on Linux

Additional context
[TIP]: # ( Add any other context about the problem here. For example, relevant community posts or support tickets. )

For Maintainers Only or Hero Triaging this bug
Suggested Priority (P1,P2,P3,P4,P5):
Suggested T-Shirt size (S, M, L, XL, Unknown):

@AnhQuanTrl AnhQuanTrl added the bug Something isn't working label Jul 2, 2024
@workato-integration
Copy link

@github-actions github-actions bot added the community To tag external issues and PRs label Jul 2, 2024
@chynesNR
Copy link
Member

chynesNR commented Jul 2, 2024

Hi @AnhQuanTrl -- thanks for your feedback. The .NET Agent does not currently instrument gRPC, so those related errors will not be captured. We have an open Feature Request to add gRPC support, but I'm afraid I don't have an expected release window for you at the moment. We will update this ticket when we have more information.

@chynesNR chynesNR added feature request To tag an issue after triage that is a feature instead of TD and removed bug Something isn't working labels Jul 2, 2024
@AnhQuanTrl
Copy link
Author

Hi @chynesNR Thank you for quick response. While waiting for this feature, I will add a custom NoticeError in a gRPC interceptor as a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs feature request To tag an issue after triage that is a feature instead of TD
Projects
None yet
Development

No branches or pull requests

2 participants