chore(install): Refactor re.setOutput to use bufio scanner #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
==========================================
- Coverage 47.53% 47.52% -0.02%
==========================================
Files 123 123
Lines 7416 7420 +4
==========================================
+ Hits 3525 3526 +1
- Misses 3747 3748 +1
- Partials 144 146 +2 ☔ View full report in Codecov by Sentry. |
amolero-nr
reviewed
Apr 17, 2023
amolero-nr
previously approved these changes
Apr 17, 2023
rthorn-nr
force-pushed
the
chore/refactor-setoutput
branch
2 times, most recently
from
a1b5ac1 to
505a862
Compare
rthorn-nr
force-pushed
the
chore/refactor-setoutput
branch
from
505a862 to
5d1129e
Compare
rthorn-nr
force-pushed
the
chore/refactor-setoutput
branch
from
5d1129e to
6302f6a
Compare
rthorn-nr
force-pushed
the
chore/refactor-setoutput
branch
from
6302f6a to
452f1a1
Compare
Julien4218
reviewed
May 24, 2023
| @@ -486,3 +484,67 @@ tasks: | |||
| assert.Empty(t, e.GetOutput().Metadata()["something"]) | |||
| assert.Equal(t, "very", e.GetOutput().Metadata()["clean"]) | |||
| } | |||
|
|
|||
| func Test_mergeStringJSON(t *testing.T) { | |||
There was a problem hiding this comment.
This is a long test, perhaps we could break it into many small tests?
Julien4218
reviewed
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes invalid JSON warning message on empty string caused by newline in output. Alternative to #1448