New config for nrsecurityagent #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nr-swilloughby
requested changes
Nov 8, 2024
| @@ -63,7 +69,7 @@ func InitSecurityAgent(app *newrelic.Application, opts ...ConfigOption) error { | |||
|
|
|||
| appConfig, isValid := app.Config() | |||
| if !isValid { | |||
| return fmt.Errorf("Newrelic application value cannot be read; did you call newrelic.NewApplication?") | |||
| return fmt.Errorf("Newrelic application value cannot be read; did you call newrelic.NewApplication?") | |||
There was a problem hiding this comment.
Is that a typo or do you intend the extra space to be added to the error string?
There was a problem hiding this comment.
yes extra space is typo.
There was a problem hiding this comment.
ok we can fix it on release.
nr-swilloughby
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new config to support the new feature release in CSEC Agent Release v1.5.0