-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Integrating Structural, Functional, and Biochemical Brain Imaging Data with MRShiny Brain - An Interactive Web Application #29
Comments
Hello humans, I'm @roboneuro, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
Failed to discover a |
@roboneuro build book |
🔴 Binder build has failed 🥀Status: Failed ℹ️ See details
|
|
🥀 We ran into a problem building your book. Please see the log files below. BinderHub build log
If the BinderHub build looks OK, please see the Jupyter Book build log(s) below. Jupyter Book build log
🐞 After inspecting the logs above, you can interactively debug your notebooks on our BinderHub server. For guidelines, please see the relevant documentation. 🐞 After inspecting the logs above, you can interactively debug your notebooks on our BinderHub server. For guidelines, please see the relevant documentation. |
@arcj-hub the error above is because your format: jb-book
root: 00-simple_markdown
parts:
- caption: Ipynb
chapters:
- file: 01-simple_notebook
- caption: MyST
chapters:
- file: 02-simple-myst Here are the steps you can follow to fix it: Step 1:
Step 2:
format: jb-book
root: summary
parts:
- caption: MRShiny Brain
chapters:
- file: notebook Thank you! |
Done!
From: Agah ***@***.***>
Reply-To: neurolibre/neurolibre-reviews ***@***.***>
Date: Wednesday, July 31, 2024 at 2:22 PM
To: neurolibre/neurolibre-reviews ***@***.***>
Cc: "Archibald, Jessica" ***@***.***>, Mention ***@***.***>
Subject: Re: [neurolibre/neurolibre-reviews] [REVIEW]: Integrating Structural, Functional, and Biochemical Brain Imaging Data with MRShiny Brain - An Interactive Web Application (Issue #29)
[CAUTION: Non-UBC Email]
@arcj-hub<https://github.com/arcj-hub> the error above is because your content/_toc.yml is not modified after cloning the template:
format: jb-book
root: 00-simple_markdown
parts:
- caption: Ipynb
chapters:
- file: 01-simple_notebook
- caption: MyST
chapters:
- file: 02-simple-myst
Here are the steps you can follow to fix it:
Step 1:
* Create a content/summary.md file and move the abstract of your article there (from the notebook).
Step 2:
* Update content/_toc.yml
format: jb-book
root: summary
parts:
- caption: MRShiny Brain
chapters:
- file: notebook
Thank you!
—
Reply to this email directly, view it on GitHub<#29 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATSCAELYWYBKUJZD2JWBX5DZPFBPRAVCNFSM6AAAAABLZBJAWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRRGM4DINBRGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@roboneuro build book |
🟢 Successfully builtStatus: Success ℹ️ See details
|
🎊🎊🎊 Good news! 🌺 Take a look at the latest version of your NRP |
Hey Agah,
Just noticed on this most recent version there is some text missing. Is this made from the paper.md?
Specifically, the thermometry info is missing. And the visual of the dashboard is cut off. Let me know what form I can edit to fix this 😊
Thanks!
From: roboneuro ***@***.***>
Reply-To: neurolibre/neurolibre-reviews ***@***.***>
Date: Wednesday, July 31, 2024 at 9:16 PM
To: neurolibre/neurolibre-reviews ***@***.***>
Cc: "Archibald, Jessica" ***@***.***>, Mention ***@***.***>
Subject: Re: [neurolibre/neurolibre-reviews] [REVIEW]: Integrating Structural, Functional, and Biochemical Brain Imaging Data with MRShiny Brain - An Interactive Web Application (Issue #29)
[CAUTION: Non-UBC Email]
🎊🎊🎊 Good news!
🌺 Take a look at the latest version of your NRP<https://preview.neurolibre.org/book-artifacts/arcj-hub/github.com/MRShiny-Brain/caeb60c5fcec333393ac089943ee04348bd1b0e3/_build/html/>
—
Reply to this email directly, view it on GitHub<#29 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATSCAEJBQXH775G6W2OHN6DZPGSBVAVCNFSM6AAAAABLZBJAWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRRHA4DANZSGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @arcj-hub, this was built from two files:
You can add the text in (I guess notebook.ipynb) and they will appear here as well.
I am in the process of deploying your dashboard to our server, once that's done, we can deal with the respective settings. On that note, it seems that most of the |
From what I can tell your dashboard only needs the following: library(shiny)
library(shinythemes)
library(plotly)
library(dplyr)
library(ggplot2)
library(DT) do you confirm, or is there something else I am missing? |
@arcj-hub nevermind, here's the dashboard :) https://shinybrain.db.neurolibre.org/ As you can see, no need to wait as we deployed with zero downtime! Right now images are missing, but will fix it quickly. |
I just updated the notebook.ipynb sorry! I forgot the text was in two places.
And that is correct, I just updated the code for the dashboard
From: Agah ***@***.***>
Reply-To: neurolibre/neurolibre-reviews ***@***.***>
Date: Thursday, August 1, 2024 at 9:26 AM
To: neurolibre/neurolibre-reviews ***@***.***>
Cc: "Archibald, Jessica" ***@***.***>, Mention ***@***.***>
Subject: Re: [neurolibre/neurolibre-reviews] [REVIEW]: Integrating Structural, Functional, and Biochemical Brain Imaging Data with MRShiny Brain - An Interactive Web Application (Issue #29)
[CAUTION: Non-UBC Email]
From what I can tell your dashboard only needs the following:
library(shiny)
library(shinythemes)
library(plotly)
library(dplyr)
library(ggplot2)
library(DT)
do you confirm, or is there something else I am missing?
—
Reply to this email directly, view it on GitHub<#29 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATSCAELDHJFRU2LZXKAIIHLZPJHUDAVCNFSM6AAAAABLZBJAWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRTGM2TIMJXGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
OK perfect, I'll update the dashboard to make it fully functional, but we are almost there. |
@arcj-hub https://shinybrain.db.neurolibre.org should be now fully functional. Please let me know if there's something not working. |
Also for completeness, these are the libraries needed:
the previous post was missing |
@arcj-hub I also noticed that your latest change to Can you revert your latest commit and re-edit the notebook using |
Hey,
I think we do need the
library(shinyWidgets) for the slider to be gray. But in the spectroscopy tab of this version: https://shinybrain.db.neurolibre.org/ It says it will be deprecated in a future release. Let me see what I can add to make this gray without Shiny Widgets.
***@***.***
And please, if you don’t mind looking at my notebook to see what the issue is. I do not use VS or jupyter. I’ve added you as a collab.
Also if I need to make changes to the app in the future, say add more subjects or data can I do this on Git and then you would redeploy?
Zero downtime it’s so cool!
From: Agah ***@***.***>
Reply-To: neurolibre/neurolibre-reviews ***@***.***>
Date: Thursday, August 1, 2024 at 10:30 AM
To: neurolibre/neurolibre-reviews ***@***.***>
Cc: "Archibald, Jessica" ***@***.***>, Mention ***@***.***>
Subject: Re: [neurolibre/neurolibre-reviews] [REVIEW]: Integrating Structural, Functional, and Biochemical Brain Imaging Data with MRShiny Brain - An Interactive Web Application (Issue #29)
[CAUTION: Non-UBC Email]
@arcj-hub<https://github.com/arcj-hub> https://shinybrain.db.neurolibre.org should be now fully functional. Please let me know if there's something not working.
—
Reply to this email directly, view it on GitHub<#29 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATSCAELZ7V3RCGALIACHV23ZPJPCHAVCNFSM6AAAAABLZBJAWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRTGQ4DCMJXGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ShinyWidgets is already included, I deployed it from my fork of your repo (https://github.com/agahkarakuzu/MRShiny-Brain) |
Hey,
I can’t replicate the slidercolour issue on my end. I am using the latest R Studio version and have added the source code (setSliderColor.R) to the repo. It is used in line 227.
If this does not work, do you mind just commenting that out? And we can leave them all blue.
From: Agah ***@***.***>
Reply-To: neurolibre/neurolibre-reviews ***@***.***>
Date: Thursday, August 1, 2024 at 1:00 PM
To: neurolibre/neurolibre-reviews ***@***.***>
Cc: "Archibald, Jessica" ***@***.***>, Mention ***@***.***>
Subject: Re: [neurolibre/neurolibre-reviews] [REVIEW]: Integrating Structural, Functional, and Biochemical Brain Imaging Data with MRShiny Brain - An Interactive Web Application (Issue #29)
[CAUTION: Non-UBC Email]
ShinyWidgets is already included, I deployed it from my fork of your repo (https://github.com/agahkarakuzu/MRShiny-Brain)
—
Reply to this email directly, view it on GitHub<#29 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATSCAENWWOVNN3EHA5QP23DZPKAT7AVCNFSM6AAAAABLZBJAWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRTG43DENZXGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@arcj-hub I added a custom.css to set slider color darkgray and commented out the line in app.R.
You can open an issue using the dashboard template to ping us. I also noticed that the dashboard grays out after a waiting a while with no activity. Is this expected? |
Amazing. And thanks for the info on how to update the dashboard!
From: Agah ***@***.***>
Reply-To: neurolibre/neurolibre-reviews ***@***.***>
Date: Thursday, August 1, 2024 at 2:50 PM
To: neurolibre/neurolibre-reviews ***@***.***>
Cc: "Archibald, Jessica" ***@***.***>, Mention ***@***.***>
Subject: Re: [neurolibre/neurolibre-reviews] [REVIEW]: Integrating Structural, Functional, and Biochemical Brain Imaging Data with MRShiny Brain - An Interactive Web Application (Issue #29)
[CAUTION: Non-UBC Email]
@arcj-hub<https://github.com/arcj-hub> I added a custom.css<https://github.com/agahkarakuzu/MRShiny-Brain/blob/main/www/custom.css> to set slider color darkgray and commented out the line in app.R.
Also if I need to make changes to the app in the future, say add more subjects or data can I do this on Git and then you would redeploy?
You can open an issue using the dashboard template<https://github.com/neurolibre/info/issues/new?assignees=&labels=dashboard&projects=&template=update-an-existing-dashboard.md&title=%5BDASHBOARD%5D> to ping us.
I also noticed that the dashboard grays out after a waiting a while with no activity. Is this expected?
—
Reply to this email directly, view it on GitHub<#29 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATSCAEIQGR37TJYCWMYCUADZPKNPXAVCNFSM6AAAAABLZBJAWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRTHE3DAMRZGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@arcj-hub as the first preprint submission with its own dashboard, I wanted to give you the MyST formatted version of your article as a gift (including a header image design): https://preview.neurolibre.org/book-artifacts/arcj-hub/github.com/MRShiny-Brain/myst/_build/html/ If you like this version, I can push necessary changes to your repository. |
Wow. I love it 🥹 thank you. Yes, please push those changes to my repository!
From: Agah ***@***.***>
Reply-To: neurolibre/neurolibre-reviews ***@***.***>
Date: Friday, August 2, 2024 at 1:08 PM
To: neurolibre/neurolibre-reviews ***@***.***>
Cc: "Archibald, Jessica" ***@***.***>, Mention ***@***.***>
Subject: Re: [neurolibre/neurolibre-reviews] [REVIEW]: Integrating Structural, Functional, and Biochemical Brain Imaging Data with MRShiny Brain - An Interactive Web Application (Issue #29)
[CAUTION: Non-UBC Email]
@arcj-hub<https://github.com/arcj-hub> as the first preprint submission with its own dashboard, I wanted to give you the MyST formatted version of your article as a gift (including a header image design):
https://preview.neurolibre.org/book-artifacts/arcj-hub/github.com/MRShiny-Brain/myst/_build/html/
If you like this version, I can push necessary changes to your repository.
—
Reply to this email directly, view it on GitHub<#29 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATSCAENODW3N2FFKKTTI7QDZPPKKJAVCNFSM6AAAAABLZBJAWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVHE4DCMJZGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sorry I forgot to respond to this
I also noticed that the dashboard grays out after a waiting a while with no activity. Is this expected?
Not expected…
From: Agah ***@***.***>
Reply-To: neurolibre/neurolibre-reviews ***@***.***>
Date: Thursday, August 1, 2024 at 2:50 PM
To: neurolibre/neurolibre-reviews ***@***.***>
Cc: "Archibald, Jessica" ***@***.***>, Mention ***@***.***>
Subject: Re: [neurolibre/neurolibre-reviews] [REVIEW]: Integrating Structural, Functional, and Biochemical Brain Imaging Data with MRShiny Brain - An Interactive Web Application (Issue #29)
[CAUTION: Non-UBC Email]
@arcj-hub<https://github.com/arcj-hub> I added a custom.css<https://github.com/agahkarakuzu/MRShiny-Brain/blob/main/www/custom.css> to set slider color darkgray and commented out the line in app.R.
Also if I need to make changes to the app in the future, say add more subjects or data can I do this on Git and then you would redeploy?
You can open an issue using the dashboard template<https://github.com/neurolibre/info/issues/new?assignees=&labels=dashboard&projects=&template=update-an-existing-dashboard.md&title=%5BDASHBOARD%5D> to ping us.
I also noticed that the dashboard grays out after a waiting a while with no activity. Is this expected?
—
Reply to this email directly, view it on GitHub<#29 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATSCAEIQGR37TJYCWMYCUADZPKNPXAVCNFSM6AAAAABLZBJAWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRTHE3DAMRZGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@roboneuro cache data |
⚪ DOWNLOAD DATAStatus: Assigned to task ℹ️ See details
|
@roboneuro cache data |
🟠 DOWNLOAD DATAStatus: In progress ℹ️ See details
|
@roboneuro cache data |
🔴 DOWNLOAD DATAStatus: Failed ℹ️ See details
|
@roboneuro cache data |
🟢 DOWNLOAD DATAStatus: Success ℹ️ See details
|
@roboneuro cache data |
🟢 DOWNLOAD DATAStatus: Success ℹ️ See details
|
Submitting author: @arcj-hub (Jessica Archibald)
Repository: https://github.com/arcj-hub/MRShiny-Brain
Branch with paper.md (empty if default branch):
Version: 4.3.2 (Rversion)
Editor: @agahkarakuzu
Reviewers: @agahkarakuzu
Reproducible preprint: Pending
Repository archive: Pending
Data archive: Pending
Book archive: Pending
Docker archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@agahkarakuzu, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @agahkarakuzu know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
@agahkarakuzu, please create your checklist typing:
@roboneuro generate my checklist
The text was updated successfully, but these errors were encountered: