Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unused --keep-going flag in build docs action #66

Open
lochhh opened this issue Oct 23, 2024 · 1 comment
Open

Drop unused --keep-going flag in build docs action #66

lochhh opened this issue Oct 23, 2024 · 1 comment

Comments

@lochhh
Copy link
Contributor

lochhh commented Oct 23, 2024

From Sphinx 8.1, --keep-going is always enabled. When --fail-on-warning is used, sphinx-build no longer exits on the first warning, but instead runs the entire build and exits with exit status 1 if any warnings were generated..
@niksirbi
Copy link
Member

If we do that, should we also constrain the sphinx version to >=8.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lochhh @niksirbi