feat: send reports on threshold failure (#479)

Author: kevinsamoei

src/index.js

@@ -203,6 +203,7 @@ const prefixString = ({ path, url, str }) => {
 };
 
 const processResults = ({ data, errors }) => {
+  const err = {};
   if (errors.length > 0) {
     const error = errors.reduce(
       (acc, { path, url, errors }) => {
@@ -227,46 +228,46 @@ const processResults = ({ data, errors }) => {
         details: '',
       },
     );
-    return {
-      error,
-    };
-  } else {
-    const reports = [];
-    return {
-      summary: data
-        .map(({ path, url, summary, shortSummary, details, report }) => {
-          const obj = { report, details };
-
-          if (summary) {
-            obj.summary = summary.reduce((acc, item) => {
-              acc[item.id] = Math.round(item.score * 100);
-              return acc;
-            }, {});
-          }
-
-          if (path) {
-            obj.path = path;
-            reports.push(obj);
-            return `Summary for directory '${chalk.magenta(
-              path,
-            )}': ${shortSummary}`;
-          }
-          if (url) {
-            obj.url = url;
-            reports.push(obj);
-            return `Summary for url '${chalk.magenta(url)}': ${shortSummary}`;
-          }
-          return `${shortSummary}`;
-        })
-        .join('\n'),
-      extraData: reports,
-    };
+    err.message = error.message;
+    err.details = error.details;
   }
+  const reports = [];
+  return {
+    error: err,
+    summary: data
+      .map(({ path, url, summary, shortSummary, details, report }) => {
+        const obj = { report, details };
+
+        if (summary) {
+          obj.summary = summary.reduce((acc, item) => {
+            acc[item.id] = Math.round(item.score * 100);
+            return acc;
+          }, {});
+        }
+
+        if (path) {
+          obj.path = path;
+          reports.push(obj);
+          return `Summary for directory '${chalk.magenta(
+            path,
+          )}': ${shortSummary}`;
+        }
+        if (url) {
+          obj.url = url;
+          reports.push(obj);
+          return `Summary for url '${chalk.magenta(url)}': ${shortSummary}`;
+        }
+        return `${shortSummary}`;
+      })
+      .join('\n'),
+    extraData: reports,
+  };
 };
 
 module.exports = {
   onPostBuild: async ({ constants, utils, inputs } = {}) => {
     const { failBuild, show } = getUtils({ utils });
+    let errorMetadata = [];
 
     try {
       const { audits } = getConfiguration({
@@ -302,35 +303,40 @@ module.exports = {
 
         if (Array.isArray(errors) && errors.length > 0) {
           allErrors.push({ path, url, errors });
-        } else {
-          data.push({
-            path,
-            url,
-            summary,
-            shortSummary,
-            details,
-            report,
-          });
         }
+        data.push({
+          path,
+          url,
+          summary,
+          shortSummary,
+          details,
+          report,
+        });
       }
 
       const { error, summary, extraData } = processResults({
         data,
         errors: allErrors,
         show,
       });
+      errorMetadata.push(...extraData);
 
-      if (error) {
+      if (error && Object.keys(error).length !== 0) {
         throw error;
       }
 
       show({ summary, extraData });
     } catch (error) {
       if (error.details) {
         console.error(error.details);
-        failBuild(`${chalk.red('Failed with error:\n')}${error.message}`);
+        failBuild(`${chalk.red('Failed with error:\n')}${error.message}`, {
+          errorMetadata,
+        });
       } else {
-        failBuild(`${chalk.red('Failed with error:\n')}`, { error });
+        failBuild(`${chalk.red('Failed with error:\n')}`, {
+          error,
+          errorMetadata,
+        });
       }
     }
   },