refactor: enable and fix no-underscore-dangle (#6254)

related to #1891

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Author: hereje

.eslintrc.cjs

@@ -23,7 +23,6 @@ module.exports = {
     // TODO: remove, so those rules are enabled
     complexity: 0,
     'no-inline-comments': 'off',
-    'no-underscore-dangle': 'off',
     'func-style': 'off',
     'max-depth': 0,
     'max-lines': 0,

tests/integration/commands/deploy/deploy.test.js

@@ -10,6 +10,7 @@ import { callCli } from '../../utils/call-cli.js'
 import { createLiveTestSite, generateSiteName } from '../../utils/create-live-test-site.js'
 import { withSiteBuilder } from '../../utils/site-builder.ts'
 
+// eslint-disable-next-line no-underscore-dangle
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
 const SITE_NAME = generateSiteName('netlify-test-deploy-')

tests/integration/commands/dev/dev-miscellaneous.test.js

@@ -13,6 +13,7 @@ import { withMockApi } from '../../utils/mock-api.js'
 import { pause } from '../../utils/pause.js'
 import { withSiteBuilder } from '../../utils/site-builder.ts'
 
+// eslint-disable-next-line no-underscore-dangle
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
 const JWT_EXPIRY = 1_893_456_000

tests/integration/commands/dev/dev.zisi.test.js

@@ -14,6 +14,7 @@ import { withDevServer } from '../../utils/dev-server.ts'
 import { withMockApi } from '../../utils/mock-api.js'
 import { withSiteBuilder } from '../../utils/site-builder.ts'
 
+// eslint-disable-next-line no-underscore-dangle
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
 const testMatrix = [{ args: [] }]

tests/integration/commands/functions-with-args/functions-with-args.test.js

@@ -8,6 +8,7 @@ import { tryAndLogOutput, withDevServer } from '../../utils/dev-server.ts'
 import { pause } from '../../utils/pause.js'
 import { withSiteBuilder } from '../../utils/site-builder.ts'
 
+// eslint-disable-next-line no-underscore-dangle
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
 const testMatrix = [{ args: [] }, { args: ['esbuild'] }]

tests/integration/frameworks/eleventy.test.js

@@ -8,6 +8,7 @@ import { afterAll, beforeAll, describe, test } from 'vitest'
 import { clientIP, originalIP } from '../../lib/local-ip.js'
 import { startDevServer } from '../utils/dev-server.ts'
 
+// eslint-disable-next-line no-underscore-dangle
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
 const context = {}

tests/integration/utils/cli-path.js

@@ -1,6 +1,7 @@
 import path from 'path'
 import { fileURLToPath } from 'url'
 
+// eslint-disable-next-line no-underscore-dangle
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
 export const cliPath = path.resolve(__dirname, '../../../bin/run.js')