Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update DENO_VERSION_RANGE #5929

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented Dec 6, 2024

Summary

  • The new noble image uses the latest deno version
  • The removed comment is out of date, because the linked ticket mentions a fix was made in 1.46.0
  • We are bumping the low end of the version because we rely on a fix for AbortSignal made in 1.39.0

TODO:

  • Before merging update required test list

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@mrstork mrstork requested a review from a team as a code owner December 6, 2024 18:27
@mrstork mrstork changed the title Update DENO_VERSION_RANGE fix: update DENO_VERSION_RANGE Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant