feat(build): support new @opennextjs/netlify plugin name #5897
+46
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
|
1 task
pieh
reviewed
Oct 23, 2024
| @@ -33,7 +33,7 @@ export class Next extends BaseFramework implements Framework { | |||
| if (this.detected) { | |||
| const nodeVersion = await this.project.getCurrentNodeVersion() | |||
| if (nodeVersion && gte(nodeVersion, '10.13.0')) { | |||
| this.plugins.push('@netlify/plugin-nextjs') | |||
| this.plugins.push('@opennextjs/netlify') | |||
There was a problem hiding this comment.
Should this use new package name for next@>=13.5.1 only and otherwise use old version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See opennextjs/opennextjs-netlify#2693.
Starting at 5.9.0 the build plugin and npm package will be renamed from
@netlify/plugin-nextjsto@opennextjs/netlify.This adds support for the new name and changes the framework detection to automatically use it going forward.
I didn't update packages/framework-info because it isn't used — see #5819.
Supersedes #5896 because I didn't know it had already been done 😁
NOTE: we shouldn't release this to buildbot and cli until the
@opennextjs/netlifypackage exists.