refactor: remove deprecated @netlify/framework-info
#5819
+65
−5,597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was replaced by @netlify/build-info a long time ago, but the entire codebase still existed to support a couple utility function calls. I refactored these away and deleted the package.
|
This pull request adds or modifies JavaScript ( |
mrstork
reviewed
Oct 25, 2024
| import type { Framework } from './frameworks/framework.js' | ||
|
|
||
| export const listFrameworks = async ({ projectDir }: { projectDir: string }): Promise<Framework[]> => { | ||
| // FIXME(serhalp) implement |
There was a problem hiding this comment.
I looked into this a little bit and noticed that all references to this function actually seem to want to know what the primary detected framework is rather than a list. Instead of reimplementing this function, we might be able to leverage existing detection functions to pass back a singular result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@netlify/framework-infowas superseded by@netlify/build-infoa long time ago, but the entire codebase seemingly still existed to support a couple utility function calls. I refactored these away and deleted the package.This isn't a breaking change, as this won't result in any releases of any packages with breaking changes. We'll just stop cutting new releases of
@netlify/framework-info, but we already stopped doing that long ago. Any remaining consumers should refactor to use@netlify/build-info.To do
listFrameworks()