fix: show incompatible plugins for major changes as well #5549
+29
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasholzer
force-pushed
the
fix/show-incompatible-plugins-for-major-version-as-well
branch
from
cf11bcd to
c18589b
Compare
eduardoboucas
previously approved these changes
Mar 14, 2024
| compatWarning !== '' && | ||
| version !== undefined && | ||
| compatibleVersion !== undefined && | ||
| // Using only the major version prevents printing this warning message when |
There was a problem hiding this comment.
Is this no longer a problem?
There was a problem hiding this comment.
Sadly this code already dates back my knowledge, but based on the comment I would assume that this "race" condition is super rare.
It might occur still but the worst case in this scenario is that we show a misleading warning in those edge cases.
Where as in the case of the next.js runtime we don't show this warnings as all (as it's a newer major by design).
I think for all new major versions that we release on plugins we still want to show why it did not used the incompatible (new major) version?
lukasholzer
force-pushed
the
fix/show-incompatible-plugins-for-major-version-as-well
branch
from
e404019 to
fe14b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Shows the incompatible plugins log for major version changes as well:
This is a small PR to just unblock the current pain. I'm currently working on a larger refactoring of this area to make it cleaner but this will take more time.
in the meanwhile we can at least see why it did not used the new version
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)