NGSTACK-1000 replace 'mb_strpos' with 'str_starts_with' method in Image fieldType handler

Ante Prkacin · Ante Prkacin · commit 2a75ac1c4462 · 2025-10-20T14:07:26.000+02:00
diff --git a/bundle/Handler/FieldType/Image.php b/bundle/Handler/FieldType/Image.php
@@ -17,7 +17,6 @@
 use Symfony\Component\HttpFoundation\RequestStack;
 
 use function ltrim;
-use function mb_strpos;
 
 final class Image extends Handler
 {
@@ -40,7 +39,7 @@ protected function getFieldValue(Field $field, string $tagName, array $params =
             try {
                 $variationUri = $this->imageVariationService->getVariation($field, $this->content->getVersionInfo(), $variationName)->uri;
 
-                if (mb_strpos($variationUri, '/') === 0 && ($request = $this->requestStack->getCurrentRequest()) !== null) {
+                if (str_starts_with($variationUri, '/') && ($request = $this->requestStack->getCurrentRequest()) !== null) {
                     $variationUri = $request->getUriForPath('/' . ltrim($variationUri, '/'));
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`	`use Symfony\Component\HttpFoundation\RequestStack;`
`18`	`18`
`19`	`19`	`use function ltrim;`
`20`		`-use function mb_strpos;`
`21`	`20`
`22`	`21`	`final class Image extends Handler`
`23`	`22`	`{`
`@@ -40,7 +39,7 @@ protected function getFieldValue(Field $field, string $tagName, array $params =`
`40`	`39`	`try {`
`41`	`40`	`$variationUri = $this->imageVariationService->getVariation($field, $this->content->getVersionInfo(), $variationName)->uri;`
`42`	`41`
`43`		`- if (mb_strpos($variationUri, '/') === 0 && ($request = $this->requestStack->getCurrentRequest()) !== null) {`
	`42`	`+ if (str_starts_with($variationUri, '/') && ($request = $this->requestStack->getCurrentRequest()) !== null) {`
`44`	`43`	`$variationUri = $request->getUriForPath('/' . ltrim($variationUri, '/'));`
`45`	`44`	`}`
`46`	`45`