Skip to content

Commit a274c67

Browse files
committed
Build out more complete code coverage in the tests.
1 parent 9477123 commit a274c67

5 files changed

+494
-36
lines changed

objectivec/GPBDescriptor.m

-4
Original file line numberDiff line numberDiff line change
@@ -1027,10 +1027,6 @@ - (BOOL)isRepeated {
10271027
return GPBExtensionIsRepeated(description_);
10281028
}
10291029

1030-
- (BOOL)isMap {
1031-
return (description_->options & GPBFieldMapKeyMask) != 0;
1032-
}
1033-
10341030
- (BOOL)isPackable {
10351031
return GPBExtensionIsPacked(description_);
10361032
}

objectivec/GPBUnknownField.m

+4-2
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ - (BOOL)isEqual:(id)object {
9797
if (self == object) return YES;
9898
if (![object isKindOfClass:[GPBUnknownField class]]) return NO;
9999
GPBUnknownField *field = (GPBUnknownField *)object;
100+
if (number_ != field->number_) return NO;
100101
BOOL equalVarint =
101102
(mutableVarintList_.count == 0 && field->mutableVarintList_.count == 0) ||
102103
[mutableVarintList_ isEqual:field->mutableVarintList_];
@@ -202,8 +203,9 @@ - (size_t)serializedSizeAsMessageSetExtension {
202203
}
203204

204205
- (NSString *)description {
205-
NSMutableString *description = [NSMutableString
206-
stringWithFormat:@"<%@ %p>: Field: %d {\n", [self class], self, number_];
206+
NSMutableString *description =
207+
[NSMutableString stringWithFormat:@"<%@ %p>: Field: %d {\n",
208+
[self class], self, number_];
207209
[mutableVarintList_
208210
enumerateValuesWithBlock:^(uint64_t value, NSUInteger idx, BOOL *stop) {
209211
#pragma unused(idx, stop)

0 commit comments

Comments
 (0)