Validate raidplaner module functionality

[karaktaka]

Context

The raidplaner module is currently disabled in production as it's unclear whether it actually works correctly. The module is the largest in the codebase with a complex state-machine-based conversation system, multiple database models, and Discord embed interactions.

Tasks

• Verify the raidplaner module loads without errors
• Test template CRUD (create, list, edit, delete)
• Test encounter and role management within templates
• Test raid event creation from templates
• Test the DM-based conversation flow (state machine, emoji reactions, text input)
• Verify database models are correctly created and persisted
• Check for any deprecated discord.py API usage
• Fix any issues found and re-enable the module

Related

Came up during #172 — the raidplaner tables may not exist in production databases since the module has never been activated. The migration in #183 handles this gracefully by skipping missing raidplaner tables.

[karaktaka]

🔍 Module Validation Report

After thorough code analysis, the raidplaner module is non-functional — it has multiple critical bugs that prevent any workflow from completing. The module was clearly never tested against a live Discord server.

✅ What Works

• Module imports without errors
• State machine architecture is structurally sound
• Conversation routing in NerdyPy.py (reactions + DM messages)
• No deprecated discord.py API usage
• Database table auto-creation via SQLAlchemy

🐛 Critical Bugs (Would Crash)

#	Location	Issue
1	raidplaner.py:23	Hardcoded guild ID — get_guild(606539392311361794) instead of ctx.guild. Locks all planning to one guild.
2	raidplaner.py:785	create_embed() doesn't exist — should be create_info_embed(). Template preview crashes.
3	raidplaner.py:494	Off-by-one in encounter selection — displays 1-indexed but accesses Encounters[idx] instead of [idx - 1].
4	raidplaner.py:262	Off-by-one in template removal — displays 0-indexed but handler rejects idx == 0 and does [idx - 1].
5	raidplaner.py:615	Off-by-one in role removal — same 0-indexed display vs 1-indexed handler mismatch.
6	models/raidplaner.py:151-156	RaidEvent.Encounters doesn't exist — no relationship defined, get_encounter_count() and create_info_embed() crash.
7	models/raidplaner.py:42-43	RaidEncounter.__str__ not defined — str(enc) in template preview shows <RaidEncounter object at 0x...>.

⚠️ Significant Design Issues

#	Issue
8	Incomplete event creation — EVENT_CREATE_START, EVENT_CREATE_END, EVENT_CREATE_CHANNEL all map to conv_create_event_template. Never collects dates or channel. Stub code.
9	Name as PK in RaidEncounterRole — role name is part of composite PK but not set at construction. Renaming a role would also break the PK. Docs claim a RoleId should exist.
10	Icon column never populated — defined on model, used in __str__, but never set by any code.
11	No conversation timeout — abandoned DM conversations persist in memory forever.
12	isNew as dynamic attribute — set as self.tmpEncounter.isNew = True outside the ORM model definition. Fragile.
13	Backwards validation logic (raidplaner.py:643-644) — set_role_name returns None, so is not None check never triggers.

📋 Checklist Status

• Verify the raidplaner module loads without errors — imports OK, but crashes immediately on use
• Test template CRUD — create/edit partially works in theory, delete has off-by-one, preview crashes
• Test encounter and role management — off-by-one bugs in selection, role PK design issue
• Test raid event creation from templates — stub code, never finished
• Test the DM-based conversation flow — state machine works but bugs block all paths
• Verify database models are correctly created and persisted — auto-creation works
• Check for any deprecated discord.py API usage — all APIs current
• Fix any issues found and re-enable the module — see recommendation below

🧪 Testing & Documentation

• Zero test coverage — the only major module without tests
• docs/raidplaner.md exists but has inconsistencies with code (documents RoleId PK that doesn't exist)

---

💡 Recommendation: Full Rewrite

Given the number and severity of issues, a full rewrite is the better path rather than patching the existing code:

1. Slash command support — the current module is prefix-only. Guild-facing commands (template management, event creation) should use slash commands. Only the interactive DM conversation flow needs to remain DM-based.
2. Fix the data model — RaidEncounterRole needs a proper RoleId PK, RaidEvent needs proper relationships, the Icon column needs a plan.
3. Complete or redesign event creation — the current flow is stub code. Needs actual date/time/channel collection and event posting.
4. Add test coverage — following the pattern in tests/modules/test_reminder.py.
5. Conversation timeout — add cleanup for abandoned DM conversations.

The state machine architecture in utils/conversation.py is solid and can be kept as-is. The rewrite scope is mainly modules/raidplaner.py and models/raidplaner.py.