Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moviemaker.rb fails on GoogleDrive.login #7

Open
danrademacher opened this issue Jan 2, 2016 · 6 comments
Open

moviemaker.rb fails on GoogleDrive.login #7

danrademacher opened this issue Jan 2, 2016 · 6 comments

Comments

@danrademacher
Copy link
Collaborator

I just tried to make a movie from the Rim Fire images at request of USFS, and it looks like the changes @kueda made to fireslurp.rb for oauth maybe need to happen in moviemaker.rb too.

Error looks like this:

moviemaker.rb:91:in `download_images': undefined method `login' for GoogleDrive:Module (NoMethodError)
    from moviemaker.rb:200:in `<main>'

Line 91:

  session = GoogleDrive.login(GOOGLE_EMAIL, GOOGLE_PASSWORD)

I suspect the changes to fireslurp.rb in this commit need to be done in moviemaker.rb as well (or some variation of same)

@danrademacher
Copy link
Collaborator Author

I think I've got this working locally. Will verify and commit if so

@kueda
Copy link
Contributor

kueda commented Jan 5, 2016

Did it work? Sorry I didn't fix this when I fixed the other script.

@danrademacher
Copy link
Collaborator Author

I have the auth working -- but it doesn't seem to download the same number of images each time, and then I was getting an error after it "finished" downloading. Ran out of time and energy over the weekend but didn't want to commit only partially working code. I'll get more info and post before the night is out

@danrademacher
Copy link
Collaborator Author

OK, pretty sure auth fixed in this branch: https://github.com/nerdsfornature/changebrackets/tree/moviemaker-fix

@kueda could you give it a try and verify? I am getting other errors after auth and download of images but I think that's more evidence that I never ran this script before and maybe I'm missing dependencies or something

@kueda
Copy link
Contributor

kueda commented Jan 6, 2016

Yeah, running into an issue with @pglotov's alignment script, which means it would need to be rebuilt with a recent version of opencv... which might not work. I've since discovered http://wiki.panotools.org/Align_image_stack, which might be a better solution to the alignment problem, but it's a bit fussy and will need some tweaking before it will work (right now it just segfaults on me when run with default settings).

@jasper2xF
Copy link

I also had problems with the GoogleDrive access. Using the up-to-date authentication as in fireslurp.rb fixed this for me. Looks like exactly what @danrademacher did.

Also note that I raised issue #9 in relation to the alignment script being deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants