Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab.Container: getLayoutConfig() => replace the switch block with an object (map) #5429

Open
tobiu opened this issue Jun 21, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tobiu
Copy link
Collaborator

tobiu commented Jun 21, 2024

No description provided.

@tobiu tobiu added enhancement New feature or request good first issue Good for newcomers labels Jun 21, 2024
Copy link

This issue is stale because it has been open for 90 days with no activity.

@TheCoderAdi
Copy link
Contributor

Hello , I have added a pull request for it , Please review the changes and add a label for hacktoberfest2024

@tobiu
Copy link
Collaborator Author

tobiu commented Sep 29, 2024

hi @TheCoderAdi!

the PR looks fine to me. I just took another look into the hacktoberfest rules, and if i understand them correctly, only PRs starting from October 1 count. If I am right on this one, you should re-send the PR on Tuesday, to ensure that you get the events credits.

Best regards,
Tobias

@TheCoderAdi
Copy link
Contributor

TheCoderAdi commented Sep 29, 2024 via email

@TheCoderAdi
Copy link
Contributor

I hope you're doing well! Since Hacktoberfest has officially started, I wanted to kindly request if you could merge the pull request I recently submitted. This will allow the contribution to count towards the event, and I'd be thrilled to see it make a positive impact.

Thank you for your time and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants