Skip to content

Commit 4716d77

Browse files
Zhen Lilutovich
Zhen Li
authored andcommitted
Default dev version to be the highest version
1 parent 3e54d8c commit 4716d77

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

src/v1/internal/server-version.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ function compareInts(x, y) {
112112
const VERSION_3_1_0 = new ServerVersion(3, 1, 0);
113113
const VERSION_3_2_0 = new ServerVersion(3, 2, 0);
114114
const VERSION_3_4_0 = new ServerVersion(3, 4, 0);
115-
const VERSION_IN_DEV = new ServerVersion(0, 0, 0);
115+
const maxVer = Number.MAX_SAFE_INTEGER;
116+
const VERSION_IN_DEV = new ServerVersion(maxVer, maxVer, maxVer);
116117

117118
export {
118119
ServerVersion,

test/internal/server-version.test.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,10 @@ describe('ServerVersion', () => {
7777
verifyVersion(parse('Neo4j/2.3-SNAPSHOT'), 2, 3, 0);
7878
verifyVersion(parse('Neo4j/2.2-M09'), 2, 2, 0);
7979

80-
verifyVersion(parse('Neo4j/dev'), 0, 0, 0);
81-
verifyVersion(parse('Neo4j/DEV'), 0, 0, 0);
82-
verifyVersion(parse('Neo4j/Dev'), 0, 0, 0);
80+
let maxVer = Number.MAX_SAFE_INTEGER;
81+
verifyVersion(parse('Neo4j/dev'), maxVer, maxVer, maxVer);
82+
verifyVersion(parse('Neo4j/DEV'), maxVer, maxVer, maxVer);
83+
verifyVersion(parse('Neo4j/Dev'), maxVer, maxVer, maxVer);
8384
});
8485

8586
it('should fetch version using driver', done => {
@@ -139,9 +140,9 @@ describe('ServerVersion', () => {
139140
});
140141

141142
it('should compare dev version', () => {
142-
expect(new ServerVersion(3, 1, 0).compareTo(VERSION_IN_DEV)).toBeGreaterThan(0);
143-
expect(new ServerVersion(3, 3, 6).compareTo(VERSION_IN_DEV)).toBeGreaterThan(0);
144-
expect(new ServerVersion(2, 3, 0).compareTo(VERSION_IN_DEV)).toBeGreaterThan(0);
143+
expect(new ServerVersion(3, 1, 0).compareTo(VERSION_IN_DEV)).toBeLessThan(0);
144+
expect(new ServerVersion(3, 3, 6).compareTo(VERSION_IN_DEV)).toBeLessThan(0);
145+
expect(new ServerVersion(2, 3, 0).compareTo(VERSION_IN_DEV)).toBeLessThan(0);
145146
});
146147

147148
});

0 commit comments

Comments
 (0)