Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels geojson is missing fields width, height, and reference level #232

Open
leendertvanwolfswinkel opened this issue Jun 7, 2024 · 0 comments
Assignees

Comments

@leendertvanwolfswinkel
Copy link
Contributor

leendertvanwolfswinkel commented Jun 7, 2024

For example this channel geojson: https://api.staging.3di.live/v3/threedimodels/16677/geojson/channels/download/

The last channel in the file (ID 47407) has a cross-section shape 1 (Open rectangle). So the width should be specified as a single value, but the geojson only contains empty cross_section_table_n fields. There is no "width" and "height" field.

The field reference_level is also missing. Note: this field is called dpumax in threedigrid.

        {
            "type": "Feature",
            "geometry": {
                "type": "LineString",
                "coordinates": [
                    [
                        5.859325,
                        50.869797
                    ],
                    [
                        5.859422,
                        50.869969
                    ]
                ]
            },
            "properties": {
                "id": 47407,
                "content_pk": 2000247,
                "code": "",
                "kcu": 2,
                "calculation_type": 102,
                "dist_calc_points": 20.0,
                "connection_node_start_pk": 2000937,
                "connection_node_end_pk": 2000936,
                "discharge_coefficient": 1.0,
                "model_type": "Channels",
                "cross_section_type_1": 1,
                "cross_section_table_1": [
                    [
                    ],
                    [
                    ]
                ],
                "cross_section_weight": 1.0,
                "cross_section_type_2": 1,
                "cross_section_table_2": [
                    [
                    ],
                    [
                    ]
                ]
            }
        }

It think these fields were there before #218 was implemented?

PS to give an idea of why this matters: we want to prevent visualisations like these:
image.png

@leendertvanwolfswinkel leendertvanwolfswinkel changed the title Channels geojson is missing width and height fields Channels geojson is missing fields width, height, and reference level Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants