Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean old parts from threedigrid #162

Open
caspervdw opened this issue Mar 18, 2022 · 0 comments
Open

Clean old parts from threedigrid #162

caspervdw opened this issue Mar 18, 2022 · 0 comments

Comments

@caspervdw
Copy link
Contributor

Now that we have a new route to produce gridadmin files, there are large parts in threedigrid that are not used anymore. Cleaning these will greatly reduce complexity of this library, making it more maintainable on the long term.

This ticket is to investigate which parts are obsolete. I think it is good to aim for a breaking release that only supports the new route. It is also good practice to explicitly list the public api (eg in api.py) so that we know where we need backwards compatibility.

A start of obsolete stuff:

  • “prepare” functionality
  • unused fields
  • lines.breaches
  • Id mapping (seq_id fields)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant