Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to fill in NULL for initial water level in the schematisation #370

Open
leendertvanwolfswinkel opened this issue Apr 18, 2024 · 1 comment

Comments

@leendertvanwolfswinkel
Copy link
Contributor

At the moment, if you do not fill in v2_global_settings.initial_waterlevel, threedi-modelchecker will give an error.

This doesn't make sense; it is perfectly valid to run a simulation without any initial water levels. However, I don't know what happens if we remove this check from threedi-modelchecker. Will making the simulation template fail? Or will the simulation template be made and will the simulation crash?

So please test what happens after removing this check when generating a 3Di model with v2_global_settings.initial_waterlevel = NULL

@elisalle
Copy link
Collaborator

elisalle commented May 6, 2024

@leendertvanwolfswinkel this should probably be an issue in a different repo, since it involves testing on the api, not the modelchecker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants