Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter on modelrevision is no longer reliable #24

Open
lexvand opened this issue Jun 9, 2022 · 0 comments
Open

Filter on modelrevision is no longer reliable #24

lexvand opened this issue Jun 9, 2022 · 0 comments

Comments

@lexvand
Copy link

lexvand commented Jun 9, 2022

In https://github.com/nens/fews-3di/blob/master/fews_3di/simulation.py#L243 the threedimodel is retrieved based on a contains filter on the slug. This is no longer reliable as the slug no longer contains a unique_id of the revision. Instead it contains the revision number. This has changed after the Klondike release of 3Di.

For example filtering on 'model-name-1' could give multiple results, i.e. 'model-name-10', 'model-name-11' et cetera.

We should change this to an exact filter on the id of the threedimodel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant