Skip to content

Commit bde0671

Browse files
committed
jfif: Remove commented out code
1 parent 7b0ac56 commit bde0671

File tree

2 files changed

+6
-27
lines changed

2 files changed

+6
-27
lines changed

jfif.go

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -238,26 +238,8 @@ func readSegments(r io.Reader, fn func(io.ReadSeeker, Pointer) error) error {
238238
return nil
239239
}
240240

241-
//// WriteTo TODO
242-
//func (seg Segment) WriteTo(w io.Writer) int64, error {
243-
// // Everything else needs the 0xff, marker and potential payload
244-
// n, err := w.Write([]byte{0xff, byte(seg.Marker)})
245-
// if err != nil || seg.Data == nil {
246-
// return n, err
247-
// }
248-
//
249-
// // Payload size includes it's own 2-bytes
250-
// // TODO Validate the length of Data here?
251-
// err = binary.Write(w, binary.BigEndian, uint16(len(seg.Data))+2)
252-
// if err != nil {
253-
// return err
254-
// }
255-
// _, err = w.Write(seg.Data)
256-
// return err
257-
//}
258-
259241
// EncodeSegment writes the given segment.
260-
func EncodeSegment(w io.Writer, seg Segment) error {
242+
func EncodeSegment(w io.Writer, seg Segment) error { // TODO Segment.WriteTo?
261243
// Everything else needs the 0xff, marker and potential payload
262244
_, err := w.Write([]byte{0xff, byte(seg.Marker)})
263245
if err != nil || seg.Data == nil {
@@ -273,8 +255,6 @@ func EncodeSegment(w io.Writer, seg Segment) error {
273255
return err
274256
}
275257

276-
277-
278258
func readByte(r io.Reader) (b byte, err error) { // TODO This is probably slow
279259
err = binary.Read(r, binary.BigEndian, &b)
280260
return

write_test.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ import (
1010
"testing"
1111
)
1212

13-
func TestFileQuery(t *testing.T) { // TODO
14-
}
15-
16-
func TestFileAppend(t *testing.T) {
13+
func TestAppend(t *testing.T) {
1714
var tests = []struct {
1815
name string
1916
ref Pointer
@@ -48,11 +45,14 @@ func TestFileAppend(t *testing.T) {
4845
defer os.Remove(path)
4946
defer temp.Close()
5047

51-
fmt.Println("TODO: TestFileAppend:", path)
48+
fmt.Println("TODO: TestAppend:", path)
5249
})
5350
}
5451
}
5552

53+
func TestFileQuery(t *testing.T) { // TODO
54+
}
55+
5656
func TestFileUpdate(t *testing.T) {
5757
var tests = []struct {
5858
name string
@@ -127,4 +127,3 @@ func TestFileUpdate(t *testing.T) {
127127
})
128128
}
129129
}
130-

0 commit comments

Comments
 (0)