Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submethod names and comments in test() #15

Open
kjellp opened this issue Sep 7, 2022 · 0 comments
Open

Update submethod names and comments in test() #15

kjellp opened this issue Sep 7, 2022 · 0 comments

Comments

@kjellp
Copy link

kjellp commented Sep 7, 2022

Is your feature request related to a problem? Please describe.
Update naming and comments in the test code to make the test code more readable/understandable.

Describe the solution you'd like
See description below

Additional context
Need to improve the naming of the methods in the test code and description of what the step is performing as comments:

upload() -> generates a random file and uploads it towards the REST API in the proxy service.
Needs an ELIXIR AAI like token to be able to upload data through this REST API
The Proxy service sends the upload message to CEGA RMQ

Wait() -> during this wait the CEGA should have time to receive and read the upload message at their end (we can probably not complete a submission and send a ingest message back before they have properly parsed the upload message internally!

ingest() -> Could be that it is impersonating CEGA and posting the ingest message back to us on behalf of CEGA. Yes: see below further down: in short - upload message is correctly sent above, but this ingest() step is impersonating the action of the user clicking “complete, I’m done with entering meta-data in this submission” in the submission portal!!!! By sending the ingest messages manually from the CEGA RMQ!

Wait() -> Is it actually here the ingest, verify and finalize microservices is doing their work? Yes. Including sending a completed message to CEGA and receiving the AccessionID message back.

verify() -> Check the state of the DB after finalize has the proper row with information for a fully ingested file (after finalize micorservice, including the StableID=FileAccessionNo)
Should be renamed to something like check_file_is_ingested_ok_after_finalize()

At this point nothing more will happen before we trigger the next step.

map() -> impersonates CEGA and triggers the map microservice with a mapping type RMQ message, with a synthetic/artifical DatasetID (not coming from CEGA)

download() -> downloads the file using the StableID in two different ways unencrypted and encruypted, asserts in each case that the checksum matches original checksum of unencrypted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant