Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients can not join muc room. #8

Open
johannesk opened this issue Mar 2, 2012 · 2 comments
Open

Clients can not join muc room. #8

johannesk opened this issue Mar 2, 2012 · 2 comments

Comments

@johannesk
Copy link

When a client on a client connection sends a presence with an explicit to jid, and this jid was not previously allowed to receive broadcast presence, the presence is not transmitted. This filtering is done in lib/vines/stanza/presence.rb:45 in revision cb72247.

I have not read the corresponding parts of the RFC, but I am fairly sure this must be wrong. If a client joins a muc(multi user chat) room as in XEP-0045, the client sends a presence to the room. Such a presence to a room is ignored. Therefore a client connected to vines can not join a muc room on any server.

@dgraham
Copy link
Member

dgraham commented Apr 25, 2012

Presence#outbound_broadcast_presence isn't handling directed presence properly as documented in RFC 6121 section 4.6.

I don't think commit cb72247 is relevant, though. That just added support for some HTTP headers. I think we've just never handled directed presence properly.

What MUC component are you using to test this?

@johannesk
Copy link
Author

I only mentioned the commit to indicate which version of vines I was using.

I was not using any real MUC component. To test this, a component which prints stanzas to stdout suffices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants