Prevent misbehaving dynamic context plugins from ruining coverage#1088
Open
s0undt3ch wants to merge 1 commit intocoveragepy:mainfrom
Open
Prevent misbehaving dynamic context plugins from ruining coverage#1088s0undt3ch wants to merge 1 commit intocoveragepy:mainfrom
s0undt3ch wants to merge 1 commit intocoveragepy:mainfrom
Conversation
69510e9 to
309f67e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1088 +/- ##
==========================================
- Coverage 91.28% 91.27% -0.02%
==========================================
Files 90 90
Lines 13358 13358
Branches 1493 1493
==========================================
- Hits 12194 12192 -2
- Misses 953 954 +1
- Partials 211 212 +1
|
Member
|
Do you have any more information about what caused the conflict? This is the type of change that can hide useful information about a problem to be fixed. I see that it would be safe to add, but I have qualms. |
Author
0c14f1a to
82169a6
Compare
Contributor
|
This branch is out of date, and submission is 2+ years ago. Can it be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a dynamic context plugin I encountered an issue where contexts are not unique(I think it's related to subprocess coverage, but I haven't been able to create a small enough example to show here).
While we can argue that the plugin itself should be fixed, this looks like an innocuous change to
coveragepywhich can prevent these misbehaving plugins from ruining most of the coverage data(not being covered).