From f65e26e08abec7a6e661565d38667cd4d4c08c70 Mon Sep 17 00:00:00 2001 From: Siarhei Bobryk Date: Sun, 6 Sep 2020 15:32:33 +0300 Subject: [PATCH 1/2] Fix the input[type="search"] documentation block Changes in README.md: 1. Remove notes about Chrome on macOS and Windows, because it's not reproduced. See attached images. Tested on macOS 10.15 and Windows 10/7. 2. Remove notes about Safari on Windows, because it's completely out-of-date and not supported anymore by normalize.css. Safari 5.1.7 was the last version supported by Windows XP/Vista/7. [Safari version history](https://en.wikipedia.org/wiki/Safari_version_history#Windows) Changes below are required to cover all cases mentioned on README.md for Safari. Changes in test.html: 1. Add some new styles: - font-family - background-color 2. Add the value attribute --- README.md | 11 ++++------- test.html | 2 +- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 71954f230..38edbe095 100644 --- a/README.md +++ b/README.md @@ -78,13 +78,10 @@ decrement button to change from `default` to `text`. #### `[type="search"]` -The search input is not fully stylable by default. In Chrome and Safari on -OSX/iOS you can't control `font`, `padding`, `border`, or `background`. In -Chrome and Safari on Windows you can't control `border` properly. It will apply -`border-width` but will only show a border color (which cannot be controlled) -for the outer 1px of that border. Applying `-webkit-appearance: textfield` -addresses these issues without removing the benefits of search inputs (e.g. -showing past searches). +The search input is not fully stylable by default. In Safari on +OSX you can't control `font`, `padding`, `border`, or `background`. Applying +`-webkit-appearance: textfield` addresses these issues without removing the +benefits of search inputs (e.g. showing past searches). ## Contributing diff --git a/test.html b/test.html index 615b08326..613843e1d 100644 --- a/test.html +++ b/test.html @@ -431,7 +431,7 @@

should display a default cursor for the decrement button's c

[type="search"]

should be styleable

- +

should reference inherited color

From 5d064ce6c78ebfcd7f30ace2030c1c2c7a484928 Mon Sep 17 00:00:00 2001 From: Siarhei Bobryk Date: Sun, 6 Sep 2020 17:13:24 +0300 Subject: [PATCH 2/2] Fix comment about `-webkit-appearance` for Chrome --- normalize.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/normalize.css b/normalize.css index 192eb9ce4..96d22b2cd 100644 --- a/normalize.css +++ b/normalize.css @@ -283,7 +283,7 @@ textarea { } /** - * 1. Correct the odd appearance in Chrome and Safari. + * 1. Correct the odd appearance in Safari. * 2. Correct the outline style in Safari. */