Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datetime in the output? #133

Closed
sylvinus opened this issue Jul 20, 2016 · 3 comments
Closed

Add datetime in the output? #133

sylvinus opened this issue Jul 20, 2016 · 3 comments

Comments

@sylvinus
Copy link

One of Flintrock's strenghts is definitely its speed, so wouldn't it make sense to show the datetime before each output line, to be able to see how much time each operation took and maybe give hints on how to optimize it further?

@sylvinus sylvinus changed the title Add datetime in the output Add datetime in the output? Jul 20, 2016
@nchammas
Copy link
Owner

nchammas commented Jul 20, 2016

This is a good suggestion.

Flintrock today already shows the total time any given operation took. A breakdown for the individual "stages", so to speak, would definitely be interesting for me and for contributors like me who are obsessed with speed.

Perhaps stats like median and max time taken for tasks in each stage (e.g. configuring ephemeral storage; installing Spark; etc.) can be shown in some minimal and unobtrusive way.

I think this fits best when it is implemented as part of #27. I would prefer not to add more to the already busy output, e.g. during launches.

Does that sound good to you?

@sylvinus
Copy link
Author

Yes! I agree it's most interesting after the launch for analysis, not necessarily while it's being done.

@nchammas
Copy link
Owner

Just realized that this request is already covered as part of #47. Closing this in favor of that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants