Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle configuration merges #47

Open
beardedeagle opened this issue Jun 12, 2019 · 0 comments
Open

Handle configuration merges #47

beardedeagle opened this issue Jun 12, 2019 · 0 comments
Assignees

Comments

@beardedeagle
Copy link

With the advent of elixir 1.9 releases, it would be good if sobelow could handle configuration merges:

-----------------------------------------------

Config.HSTS: HSTS Not Enabled - Medium Confidence


HSTS configuration details could not be found in `releases.exs`.

In this case, the following is in prod.exs

force_ssl: [hsts: true],

But it is not present in releases.exs. The reason config merging would be desirable is because if one is using sobelow, it would allow for deduplication of configuration options which currently sobelow forces onto users. Additionally it makes sense for something like this to be an explicit compile time concern and not something someone could come in and edit at runtime via the releases.exs file present in releases.

@GriffinMB GriffinMB self-assigned this Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants