Skip to content

Commit dc40139

Browse files
Change devcontainer to use image+features (dotnet#16335)
* Change devcontainer to use image+features * Update devcontainer.json * Fixes * Update devcontainer.json Co-authored-by: Petr <[email protected]> --------- Co-authored-by: Petr <[email protected]>
1 parent 9123c41 commit dc40139

File tree

2 files changed

+17
-38
lines changed

2 files changed

+17
-38
lines changed

.devcontainer/Dockerfile

Lines changed: 0 additions & 27 deletions
This file was deleted.

.devcontainer/devcontainer.json

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
// For format details, see https://aka.ms/vscode-remote/devcontainer.json or this file's README at:
22
{
3-
"name": "F# (.NET 8)",
4-
"build": {
5-
"dockerfile": "Dockerfile",
6-
"args": {
7-
// Update 'VARIANT' to pick a .NET Core version: 3.1, 5.0, 6.0, 7.0, 8.0, etc.
8-
// Append -bullseye(-slim), -focal, or -jammy to pin to an OS version.
9-
"VARIANT": "8.0.100-rc.1-bookworm-slim-amd64"
10-
}
3+
"name": "F#",
4+
"image": "mcr.microsoft.com/dotnet/sdk:8.0.100-rc.1",
5+
"features": {
6+
"ghcr.io/devcontainers/features/common-utils:2": {},
7+
"ghcr.io/devcontainers/features/git:1": {},
8+
"ghcr.io/devcontainers/features/github-cli:1": {
9+
"version": "2"
10+
},
11+
"ghcr.io/devcontainers/features/dotnet:2": {}
1112
},
1213
"hostRequirements": {
1314
"cpus": 2,
@@ -18,13 +19,18 @@
1819
"vscode": {
1920
// Add the IDs of extensions you want installed when the container is created.
2021
"extensions": [
22+
"GitHub.copilot",
23+
"GitHub.vscode-github-actions",
24+
"ms-dotnettools.vscode-dotnet-runtime",
25+
"ms-dotnettools.csdevkit",
2126
"ms-dotnettools.csharp",
2227
"Ionide.Ionide-fsharp",
2328
"tintoy.msbuild-project-tools"
2429
]
2530
}
2631
},
27-
28-
"onCreateCommand": [ "dotnet", "build", "FSharp.Compiler.Service.sln"],
29-
"waitFor": "onCreateCommand"
32+
"remoteEnv": {
33+
"TARGET": "net8.0"
34+
},
35+
"postCreateCommand": [ "dotnet", "build", "FSharp.Compiler.Service.sln"]
3036
}

0 commit comments

Comments
 (0)