This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Fix Main #152
Merged
Fix Main #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…returning. Also refactored slightly to have it return a sorted list of VLANs based on VLAN ID
Add Check for Relationship - Fix 138
jdrew82
requested review from
jtdub,
smk4664,
glennmatthews,
chadell and
qduk
as code owners
qduk
approved these changes
Oct 19, 2023
jdrew82
added a commit
that referenced
this pull request
Oct 20, 2023
* build: Update project dependencies in lockfile * chore: 🔧 Enable commit_version_number in semantic-release * test: 🚨 Fixes for black linter * Fix Main (#152) * chore: 🚚 Update test file name to match filepath of file being tested * style: 🚨 Fix formatting for black * build: Update to latest syntax for compose * build: Use Postgres 13 for Apple ARM support * fix: 🐛 Add check for existence of Relationship in source list before returning. Also refactored slightly to have it return a sorted list of VLANs based on VLAN ID * test: ✅ Add tests validating Nautobot utility methods * build: Update lockfile for latest dependencies * build: Set upper bound on nautobot-ssot to prevent conflict. * build: Update Dockerfile to latest pattern pinning poetry. * ci: Update CI to latest pattern and lock Nautobot version. * build: Remove extras all * ci: Remove py3.7 from unit tests * ci: Remove mySQL tests, simplify unittest matrix * build: Update lockfile * fix: Redo lockfile as messed up in merge * test: Address yamllint complaints --------- Co-authored-by: Justin Drew <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the issues with main so we can merge back to develop in #136.