Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slurpit Bugs #710

Open
lpconsulting321 opened this issue Feb 24, 2025 · 0 comments · May be fixed by #711
Open

Slurpit Bugs #710

lpconsulting321 opened this issue Feb 24, 2025 · 0 comments · May be fixed by #711
Labels
integration: slurpit Issues/PRs for Slurpit! integration. type: bug Issues/PRs addressing a bug.

Comments

@lpconsulting321
Copy link
Contributor

Environment

  • Python version: 3.10
  • Nautobot version: latest
  • nautobot-ssot version: latest

Observed Behavior

Few bugs observed in production:

Traceback (most recent call last):
  File "/opt/nautobot/lib64/python3.11/site-packages/celery/app/trace.py", line 477, in trace_task
    R = retval = fun(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^
  File "/opt/nautobot/lib64/python3.11/site-packages/celery/app/trace.py", line 760, in __protected_call__
    return self.run(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/nautobot/lib64/python3.11/site-packages/nautobot/extras/jobs.py", line 1241, in run_job
    result = job(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^
  File "/opt/nautobot/lib64/python3.11/site-packages/nautobot/extras/jobs.py", line 161, in __call__
    return self.run(*args, **deserialized_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/nautobot/lib64/python3.11/site-packages/nautobot_ssot/integrations/slurpit/jobs.py", line 142, in run
    super().run(dryrun=dryrun, memory_profiling=memory_profiling, *args, **kwargs)
  File "/opt/nautobot/lib64/python3.11/site-packages/nautobot_ssot/jobs/base.py", line 354, in run
    self.sync_data(memory_profiling)
  File "/opt/nautobot/lib64/python3.11/site-packages/nautobot_ssot/jobs/base.py", line 171, in sync_data
    self.load_target_adapter()
  File "/opt/nautobot/lib64/python3.11/site-packages/nautobot_ssot/integrations/slurpit/jobs.py", line 112, in load_target_adapter
    self.target_adapter.load()
  File "/opt/nautobot/lib64/python3.11/site-packages/nautobot_ssot/contrib/adapter.py", line 175, in load
    self._load_objects(diffsync_model)
  File "/opt/nautobot/lib64/python3.11/site-packages/nautobot_ssot/integrations/slurpit/diffsync/adapters/nautobot.py", line 29, in _load_objects
    self._load_single_object(database_object, diffsync_model, parameter_names)
  File "/opt/nautobot/lib64/python3.11/site-packages/nautobot_ssot/contrib/adapter.py", line 150, in _load_single_object
    self.add(diffsync_model)
  File "/opt/nautobot/lib64/python3.11/site-packages/diffsync/__init__.py", line 810, in add
    return self.store.add(obj=obj)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/nautobot/lib64/python3.11/site-packages/diffsync/store/local.py", line 107, in add
    raise ObjectAlreadyExists(f"Object {uid} already present", obj)
diffsync.exceptions.ObjectAlreadyExists: ('Object 10.0.0.0 already present', prefix "10.0.0.0")

New custom fields (System of Record and Last sync from System of Record) should be allowed to be None, since when the custom fields are created, those fields will not have a value. Without those fields filled in, the SSOT job fails with a Pydantic exception because it expect str in those fields, but they are None.

Allow scheduling

lpconsulting321 added a commit to lpconsulting321/nautobot-app-ssot that referenced this issue Feb 24, 2025
@lpconsulting321 lpconsulting321 linked a pull request Feb 24, 2025 that will close this issue
6 tasks
@jdrew82 jdrew82 added type: bug Issues/PRs addressing a bug. integration: slurpit Issues/PRs for Slurpit! integration. labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: slurpit Issues/PRs for Slurpit! integration. type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants