Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#476 AttributeError on Sync get_source_url #493

Conversation

Renrut5
Copy link
Contributor

@Renrut5 Renrut5 commented Jul 30, 2024

Closes #476

@Renrut5 Renrut5 requested a review from a team as a code owner July 30, 2024 17:16
@Renrut5 Renrut5 changed the title Add exeption to get_target_url #476 AttributeError on Sync get_source_url Jul 30, 2024
@Renrut5
Copy link
Contributor Author

Renrut5 commented Jul 30, 2024

I noticed the get_target_url() also had the same structure as the method causing errors so I added an exception to that method as well.

Exception surrounds just the class_path assignment so not to interfere with any raises in the reverse() calls.

@Renrut5 Renrut5 marked this pull request as draft August 5, 2024 13:24
@Renrut5
Copy link
Contributor Author

Renrut5 commented Aug 5, 2024

Note: I've been unable to recreate issue as described, so may need someone else who has had issue or can recreate it to verify fixes.

@Renrut5 Renrut5 marked this pull request as ready for review August 5, 2024 14:23
@jdrew82 jdrew82 added the type: bug Issues/PRs addressing a bug. label Aug 21, 2024
@jdrew82
Copy link
Contributor

jdrew82 commented Aug 23, 2024

@Renrut5 were we ever able to reproduce the issue that caused this update to be made? I'm hesitant to make a change if the issue isn't happening repeatedly.

@Renrut5
Copy link
Contributor Author

Renrut5 commented Aug 26, 2024

@jdrew82 I was personally unable to reproduce it.

@jdrew82
Copy link
Contributor

jdrew82 commented Aug 26, 2024

If we can't reproduce it I think we'll have to close this out for now. If it comes back up we can revisit.

@jdrew82 jdrew82 closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to open /plugins/ssot/history/ on one of my nautobot instance
2 participants