Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nautobot 1.5.3 makes test fail #80

Open
chadell opened this issue Dec 5, 2022 · 1 comment
Open

Nautobot 1.5.3 makes test fail #80

chadell opened this issue Dec 5, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@chadell
Copy link
Contributor

chadell commented Dec 5, 2022

Environment

  • Python version: 3.8
  • Nautobot version: 1.5.3
  • nautobot-netbox-importer version: 1.4.2

Expected Behavior

Unittests pass

Observed Behavior

System check identified no issues (0 silenced).
..........
======================================================================
FAIL: test_imported_data_correctness (nautobot_netbox_importer.tests.test_import.TestImport) (content_type='extras.customfield', ids={'name': 'Custom Text Field A'})
Iterate over all imported data and check its correctness.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/source/nautobot_netbox_importer/tests/test_import.py", line 104, in test_imported_data_correctness
    self.assertEqual(expected_value, actual_value, f"key '{key}' on {model} '{record}' is incorrect")
AssertionError: '' != 'Custom Text Field A'
+ Custom Text Field A : key 'label' on customfield 'Custom Text Field A' is incorrect

======================================================================
FAIL: test_imported_data_correctness (nautobot_netbox_importer.tests.test_import_objectchange.TestImportObjectChange) (content_type='extras.customfield', ids={'name': 'Custom Text Field A'})
Iterate over all imported data and check its correctness.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/source/nautobot_netbox_importer/tests/test_import.py", line 104, in test_imported_data_correctness
    self.assertEqual(expected_value, actual_value, f"key '{key}' on {model} '{record}' is incorrect")
AssertionError: '' != 'Custom Text Field A'
+ Custom Text Field A : key 'label' on customfield 'Custom Text Field A' is incorrect

----------------------------------------------------------------------
Ran 12 tests in 37.242s

Steps to Reproduce

  1. invoke unittest
@glennmatthews
Copy link
Contributor

Probably a consequence of nautobot/nautobot#2136:

label is still not a mandatory field on the database model, but the UI now treats it as required, and if left unset when creating a new CustomField or migrating from 1.3, it will default to copying the name value into label.

@glennmatthews glennmatthews added the bug Something isn't working label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants