Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags not pushed via API to several models after upgrade to 2.x #392

Closed
joaopsys opened this issue Dec 5, 2024 · 1 comment
Closed

Tags not pushed via API to several models after upgrade to 2.x #392

joaopsys opened this issue Dec 5, 2024 · 1 comment
Assignees
Labels
type: bug Something isn't working as expected

Comments

@joaopsys
Copy link

joaopsys commented Dec 5, 2024

Environment

  • Python version: 3.11
  • Nautobot version: 2.3.12
  • nautobot-device-lifecycle-mgmt version: 2.2.0

Expected Behavior

I expected to be able to add tags to models like Software and Hardware Notices, just like I can through the GUI and also like I could in 1.x

Observed Behavior

Tags are passed on the API call but never added to the objects when created in Nautobot

Steps to Reproduce

  1. Create a new Software or Hardware Notice with tags via the API
  2. Notice how the tags are not added

We have fixed this in our side by adding TaggedModelSerializerMixin to the missing models in https://github.com/nautobot/nautobot-app-device-lifecycle-mgmt/blob/483d15d7cbed29db505eed8fad57854f7592afb4/nautobot_device_lifecycle_mgmt/api/serializers.py#L60C1-L67C27

This was working in 1.x, is there a technical reason why we shouldn't do it in 2.x? This has been done for other models in https://github.com/nautobot/nautobot-app-device-lifecycle-mgmt/pull/355/files

@gsnider2195 gsnider2195 added the type: bug Something isn't working as expected label Dec 6, 2024
@smk4664
Copy link
Contributor

smk4664 commented Jan 29, 2025

This was resolved by #401 but needs a release, we are working on getting a release out.

@smk4664 smk4664 self-assigned this Jan 29, 2025
@smk4664 smk4664 mentioned this issue Jan 29, 2025
@smk4664 smk4664 closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

3 participants