Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decommissioning of config_context reverts to the initial state without honouring non-tracked keys #166

Open
chadell opened this issue Jun 10, 2024 · 2 comments
Labels
type: bug Something isn't working as expected

Comments

@chadell
Copy link
Contributor

chadell commented Jun 10, 2024

Environment

  • Python version:
  • Nautobot version: 1.6.22
  • nautobot-design-builder version: 1.3.0

Expected Behavior

When a local_config_context is modified by a design deployment, only the keys defined by the deployment should be reverted when the design deployment decommissioned

For example:

  • initial state: null
  • changed by design: { "mpls_enabled": true }
  • manually updated: { "mpls_enabled": true, "something": "else" }
  • expected result: { "something": "else" }

Observed Behavior

However, this was the result:

  • actual result when decommissioning: null

Steps to Reproduce

@chadell chadell added the type: bug Something isn't working as expected label Jun 10, 2024
@abates
Copy link
Contributor

abates commented Oct 25, 2024

@chadell can you confirm if this behavior exists in Design Builder 2.1? We included tests and refactored the code for this behavior. If the problem does not exist in 2.1 I will back-port the changes to 1.4.

@chadell
Copy link
Contributor Author

chadell commented Oct 28, 2024

Hi @abates ,

I have tested with the current develop branch, and I still see the behavior.

Steps to reproduce:

  • Deploy the "P2P Connection" design. It updates the local config context of the 2 devices involved.
  • Update manually the local config context of one of the devices with a new key/value.
  • Decommission the design deployment
  • The Local Config Context is reset to {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants