Updates for docker compose plugin. #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanderaa
requested review from
glennmatthews,
smk4664 and
whitej6
as code owners
smk4664
requested changes
Jun 2, 2023
|
The MKDocs stuff should really move to something with |
|
@smk4664 can we merge this? I just set up a new system and needed to re-implement this change just to get to doing some work. |
smk4664
reviewed
Jul 22, 2023
| @@ -99,6 +99,8 @@ def docker_compose(context, command, **kwargs): | |||
| "PYTHON_VER": context.nautobot_chatops.python_ver, | |||
| **kwargs.pop("env", {}), | |||
| } | |||
|
|
|||
| compose_command = f'docker compose --project-name {context.nautobot_chatops.project_name} --project-directory "{context.nautobot_chatops.compose_dir}"' | |||
There was a problem hiding this comment.
I don't understand this change, it is just going to be overridden a few lines below when it joins the compose command tokens.
There was a problem hiding this comment.
What is the difference between the tokens and this? It was a merge conflict, and I am not familiar with command tokens.
There was a problem hiding this comment.
#212 Replaced docker-compose with docker compose among other changes. I believe this is why you get the merge conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #191
What's Changed
Moves from docker-compose standalone to docker compose plugin
TODO