Dev Updates #188
Closed
Dev Updates #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanderaa
requested review from
glennmatthews,
smk4664 and
whitej6
as code owners
| @@ -21,6 +21,8 @@ services: | |||
| depends_on: | |||
| - "postgres" | |||
| - "redis" | |||
| healthcheck: | |||
There was a problem hiding this comment.
I was just thinking about this... I think we should do this, but it should be in docker-compose.dev.yml instead.
There was a problem hiding this comment.
I can get this moved, but brings up another question, what is the point of the docker-compose.dev.yml compared to docker-compose.yml within the development directory? Is it a bit too many files then, since everything in the directory should be a development file.
It's just a question that I really don't have an answer for.
cmsirbu
reviewed
Apr 4, 2023
There was a problem hiding this comment.
Shouldn't this be in the .github folder?
|
Too complex of updates. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #187
What's Changed
TODO